From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] make mc13783 code generic
Date: Tue, 30 Nov 2010 15:35:06 +0100 [thread overview]
Message-ID: <20101130143506.GJ20449@pengutronix.de> (raw)
In-Reply-To: <878w0buqd9.fsf@lechat.rtp-net.org>
Hello,
On Tue, Nov 30, 2010 at 10:12:34AM +0100, Arnaud Patard wrote:
> > diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
> > index bff8157..4008bf6 100644
> > --- a/drivers/regulator/Makefile
> > +++ b/drivers/regulator/Makefile
> > @@ -29,7 +29,7 @@ obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o
> > obj-$(CONFIG_REGULATOR_DA903X) += da903x.o
> > obj-$(CONFIG_REGULATOR_PCF50633) += pcf50633-regulator.o
> > obj-$(CONFIG_REGULATOR_PCAP) += pcap-regulator.o
> > -obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o
> > +obj-$(CONFIG_REGULATOR_MC13783) += mc13783-regulator.o mc13xxx-regulator-core.o
> > obj-$(CONFIG_REGULATOR_AB3100) += ab3100.o
>
> Why don't you add a common Kconfig entry ? I've the (wrong ?) feeling
> that you're going to do :
> obj-$(CONFIG_REGULATOR_MC13892) += mc13892-regulator.o mc13xxx-regulator-core.o
>
> which should be avoided. Being able to build mc13783 and mc13892 support
> at the same time is a must-have imho.
AFAIK using this idiom is just fine. You could argue that it's cleaner
to have a CONFIG_REGULATOR_MC13XXX, but the result should be identical.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-11-30 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 6:26 [PATCH] make mc13783 code generic Yong Shen
2010-11-30 9:12 ` Arnaud Patard (Rtp)
2010-11-30 9:47 ` Yong Shen
2010-12-02 14:28 ` Uwe Kleine-König
2010-12-03 6:34 ` Yong Shen
2010-11-30 14:35 ` Uwe Kleine-König [this message]
2010-11-30 9:41 ` Alberto Panizzo
2010-11-30 9:50 ` Yong Shen
2010-11-30 14:32 ` Uwe Kleine-König
2010-11-30 14:55 ` Mark Brown
2010-11-30 15:15 ` Uwe Kleine-König
2010-11-30 15:17 ` Mark Brown
2010-12-01 6:07 ` Yong Shen
-- strict thread matches above, loose matches on Subject: below --
2010-11-30 6:11 Yong Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130143506.GJ20449@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).