From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] [ARM] gic: Unmask private interrupts on all cores during IRQ enable
Date: Tue, 30 Nov 2010 18:07:18 +0000 [thread overview]
Message-ID: <20101130180718.GB8521@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1288820762-16077-1-git-send-email-scaudle@codeaurora.org>
On Wed, Nov 03, 2010 at 05:46:02PM -0400, Stephen Caudle wrote:
> Some multi-core ARM chips designate a unique IRQ number for each core for
> private peripheral interrupts (PPIs). Others designate a common IRQ number
> for all cores. In the latter case, requesting/freeing private peripheral
> interrupts currently unmasks/masks the interrupt for only the
> executing core, respectively.
>
> With this change, request_irq will unmask a PPI on all cores so a separate
> call to enable_irq on the other cores is not required. Likewise, free_irq
> will mask a PPI on the other cores. Also, shutdown is implemented instead
> of disable to allow for lazy IRQ disabling.
Sorry, missed this.
If it's a private peripheral, it can only be accessed from its associated
CPU. What that means is you don't want to enable the interrupt on other
CPUs as the peripheral may not be present or initialized on that CPU.
So I'm nervous about this change - architecturally it feels like the
wrong thing to do to take the PPI interrupts through the generic IRQ
infrastructure.
next prev parent reply other threads:[~2010-11-30 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 21:46 [PATCH v2] [ARM] gic: Unmask private interrupts on all cores during IRQ enable Stephen Caudle
2010-11-30 15:42 ` Stephen Caudle
2010-11-30 18:07 ` Russell King - ARM Linux [this message]
2010-12-01 16:36 ` Stephen Caudle
2010-12-01 17:14 ` Russell King - ARM Linux
2010-12-09 16:24 ` Stephen Caudle
2010-12-16 14:54 ` Stephen Caudle
2010-12-16 15:03 ` Russell King - ARM Linux
2010-12-16 15:08 ` Stephen Caudle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130180718.GB8521@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).