From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: mx5: fix keypad clock name
Date: Tue, 30 Nov 2010 20:20:05 +0100 [thread overview]
Message-ID: <20101130192005.GV20449@pengutronix.de> (raw)
In-Reply-To: <1291144416-25197-1-git-send-email-fabio.estevam@freescale.com>
Hello Fabio,
On Tue, Nov 30, 2010 at 05:13:36PM -0200, Fabio Estevam wrote:
> This fixes the following error during keypad driver probe:
>
> imx-keypad imx-keypad: failed to get keypad clock
> imx-keypad: probe of imx-keypad failed with error -2
>
> commit 3f88014 (ARM: imx: dynamically allocate imx-keypad devices)
> uses id=-1 for imx_kpp_device, so change the clock name accordingly.
This is true, but the reasoning is broken. 3f88014 uses -1, but only
with your patch that makes mx51 use the function introduced in 3f88014
this becomes a problem for mx51.
I suggest to squash this into your patch and adding a short notice to
the commit log why this is necessary.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2010-11-30 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 19:13 [PATCH v2] ARM: mx5: fix keypad clock name Fabio Estevam
2010-11-30 19:20 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130192005.GV20449@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).