From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] ARM: VExpress: Switch to generic SCU routines
Date: Tue, 30 Nov 2010 23:27:23 +0000 [thread overview]
Message-ID: <20101130232723.GA14383@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20101130171701.GC24034@oksana.dev.rtsoft.ru>
On Tue, Nov 30, 2010 at 08:17:01PM +0300, Anton Vorontsov wrote:
> +/* If there are more than one CPU let them know where to start. */
> +static void __init smp_point_cpus(void)
> +{
> + if (num_present_cpus() <= 1)
> + return;
>
> - for (i = 0; i < ncores; i++)
> - set_cpu_possible(i, true);
> + writel(~0, MMIO_P2V(V2M_SYS_FLAGSCLR));
> + writel(BSYM(virt_to_phys(scu_secondary_startup)),
> + MMIO_P2V(V2M_SYS_FLAGSSET));
> }
I don't see the point of separating this code from the code below. It
doesn't seem to bring any benefit. Could you explain why it's necessary
to separate this?
> void __init smp_prepare_cpus(unsigned int max_cpus)
> {
...
next prev parent reply other threads:[~2010-11-30 23:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 17:16 [PATCH v4 0/8] SMP support for CNS3xxx + some SMP SCU cleanups Anton Vorontsov
2010-11-30 17:16 ` [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup Anton Vorontsov
2010-11-30 22:24 ` Russell King - ARM Linux
2010-11-30 23:32 ` Russell King - ARM Linux
2010-12-01 0:25 ` Russell King - ARM Linux
2010-12-02 15:19 ` Catalin Marinas
2010-12-02 15:24 ` Russell King - ARM Linux
2010-12-02 16:28 ` Catalin Marinas
2010-12-02 17:38 ` Russell King - ARM Linux
2010-12-02 17:55 ` Catalin Marinas
2010-12-02 18:01 ` Russell King - ARM Linux
2010-12-04 8:48 ` Russell King - ARM Linux
2010-12-06 7:28 ` [PATCH 1/8] ARM: SCU: Add common routines for secondary CPUbootup Santosh Shilimkar
2010-12-01 6:21 ` [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup Srinidhi Kasagar
2010-11-30 17:17 ` [PATCH 2/8] ARM: cns3xxx: Add support for SMP Anton Vorontsov
2010-11-30 18:14 ` Russell King - ARM Linux
2010-11-30 17:17 ` [PATCH 3/8] ARM: VExpress: Switch to generic SCU routines Anton Vorontsov
2010-11-30 23:27 ` Russell King - ARM Linux [this message]
2010-11-30 17:17 ` [PATCH 4/8] ARM: RealView: " Anton Vorontsov
2010-11-30 17:17 ` [PATCH 5/8] ARM: S5PV310: " Anton Vorontsov
2010-11-30 17:17 ` [PATCH 6/8] ARM: ux500: " Anton Vorontsov
2010-11-30 17:17 ` [PATCH 7/8] ARM: tegra: " Anton Vorontsov
2010-11-30 17:17 ` [PATCH 8/8] ARM: OMAP2: " Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130232723.GA14383@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).