From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: supply per-instance regulator name
Date: Thu, 2 Dec 2010 11:57:00 +0000 [thread overview]
Message-ID: <20101202115700.GF29347@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1291289707-5529-1-git-send-email-linus.walleij@stericsson.com>
On Thu, Dec 02, 2010 at 12:35:07PM +0100, Linus Walleij wrote:
> On the Ux500 we have different regulators to different card slots
> and eMMCs, and some have no regulator. Move the hardcoded "vmmc"
> regulator name to platform data and supply it that way for the
> platforms that use it. Remove the ugly and unneeded #ifdef around
> the regulator fetch code at the same time.
It seems that the regulator code is making all the same mistakes that
historically were made with the clk API code.
Rather than using the struct device, it's trying to use the regulator
name to distinguish individual sources of supply. This can only lead
to lots of regulator names being passed around from layer to layer,
rather than the now proven cleaner method that the clk API always set
out to do.
I'd like regulator people to think long and hard about the sanity of
passing names all the way from platform code into drivers and back
into the regulator code before I consider this patch any further.
next prev parent reply other threads:[~2010-12-02 11:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 11:35 [PATCH] mmci: supply per-instance regulator name Linus Walleij
2010-12-02 11:57 ` Russell King - ARM Linux [this message]
2010-12-02 12:06 ` Mark Brown
2010-12-02 12:03 ` Mark Brown
2010-12-02 12:28 ` Russell King - ARM Linux
2010-12-02 13:08 ` Mark Brown
2010-12-02 13:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202115700.GF29347@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox