From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: supply per-instance regulator name
Date: Thu, 2 Dec 2010 12:28:27 +0000 [thread overview]
Message-ID: <20101202122827.GG29347@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20101202120318.GB3182@sirena.org.uk>
On Thu, Dec 02, 2010 at 12:03:18PM +0000, Mark Brown wrote:
> On Thu, Dec 02, 2010 at 12:35:07PM +0100, Linus Walleij wrote:
> > On the Ux500 we have different regulators to different card slots
> > and eMMCs, and some have no regulator. Move the hardcoded "vmmc"
> > regulator name to platform data and supply it that way for the
>
> You should never be passing regulator names through platform data, this
> appears to be broken. You should be using the struct device to
> distingish between multiple instances and using whatever the actual
> supply names are for multiple supplies on the same device.
>
> Looking at this without seeing the datasheet I'd expect these would end
> up as vmmcn for suitable values of n.
The way the MMCI code is, it only requests one regulator per AMBA
device, and therefore only one regulator per struct device. So I
don't think the current code needs changing in any way provided the
struct device is used to find the corresponding regulator.
next prev parent reply other threads:[~2010-12-02 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 11:35 [PATCH] mmci: supply per-instance regulator name Linus Walleij
2010-12-02 11:57 ` Russell King - ARM Linux
2010-12-02 12:06 ` Mark Brown
2010-12-02 12:03 ` Mark Brown
2010-12-02 12:28 ` Russell King - ARM Linux [this message]
2010-12-02 13:08 ` Mark Brown
2010-12-02 13:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202122827.GG29347@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox