From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices
Date: Thu, 2 Dec 2010 23:14:57 +0000 [thread overview]
Message-ID: <20101202231457.GA12385@pulham.picochip.com> (raw)
In-Reply-To: <4CF7D9E6.5000409@samsung.com>
On Thu, Dec 02, 2010 at 06:39:50PM +0100, Sylwester Nawrocki wrote:
> On 12/02/2010 06:15 PM, Jamie Iles wrote:
> > On Thu, Dec 02, 2010 at 05:37:41PM +0100, Sylwester Nawrocki wrote:
[...]
> >> +static struct resource s5p_csis_resource[] = {
> >> + [0] = {
> >> + .start = S5P_PA_CSIS0,
> >> + .end = S5P_PA_CSIS0 + SZ_4K - 1,
> >> + .flags = IORESOURCE_MEM,
> >> + },
> >> + [1] = {
> >> + .start = IRQ_MIPICSI0,
> >> + .end = IRQ_MIPICSI0,
> >> + .flags = IORESOURCE_IRQ,
> >> + }
> >> +};
> > Do you really need the [0] and [1] here? These are only needed if you are
> > sparsely initialising an array.
>
> I agree explicit indices are not really needed. I just followed the style of
> all other resource definitions already there.
> I am not quite sure what is the preference of the maintainer, I guess they want
> all devices to follow same style for consistence.
Ok, that's fair enough, it just looked a bit odd to me!
Jamie
next prev parent reply other threads:[~2010-12-02 23:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 16:37 [PATCH 0/4] ARM: S5P: Add platform support for MIPI-CSI2 devices Sylwester Nawrocki
2010-12-02 16:37 ` [PATCH 1/4] mach-s5pv210: Add platform definitions for mipi-csis Sylwester Nawrocki
2010-12-03 4:22 ` Kukjin Kim
2010-12-03 5:30 ` Kyungmin Park
2010-12-03 8:19 ` Kukjin Kim
2010-12-03 8:32 ` Kukjin Kim
2010-12-03 15:38 ` Sylwester Nawrocki
2010-12-03 13:23 ` Sylwester Nawrocki
2010-12-02 16:37 ` [PATCH 2/4] mach-s5pv310: Add resource " Sylwester Nawrocki
2010-12-03 4:36 ` Kukjin Kim
2010-12-03 4:59 ` Jassi Brar
2010-12-03 5:34 ` Kyungmin Park
2010-12-03 5:52 ` Jassi Brar
2010-12-03 10:24 ` Sylwester Nawrocki
2010-12-02 16:37 ` [PATCH 3/4] plat-s5p: Add platform support for MIPI-CSI2 devices Sylwester Nawrocki
2010-12-02 17:15 ` Jamie Iles
2010-12-02 17:39 ` Sylwester Nawrocki
2010-12-02 23:14 ` Jamie Iles [this message]
2010-12-03 1:37 ` Jassi Brar
2010-12-03 9:18 ` Jamie Iles
2010-12-03 9:59 ` Marek Szyprowski
2010-12-03 4:53 ` Kukjin Kim
2010-12-03 13:48 ` Sylwester Nawrocki
2010-12-03 5:14 ` Jassi Brar
2010-12-03 5:36 ` Kyungmin Park
2010-12-02 16:37 ` [PATCH 4/4] mach-s5pv210: Add MIPI-CSI DPHY clock definition Sylwester Nawrocki
2010-12-03 4:11 ` [PATCH 0/4] ARM: S5P: Add platform support for MIPI-CSI2 devices Kukjin Kim
2010-12-03 10:00 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202231457.GA12385@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).