* [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
@ 2010-11-26 17:06 Vasiliy Kulikov
2010-11-29 15:29 ` Kevin Hilman
2010-12-06 23:51 ` Tony Lindgren
0 siblings, 2 replies; 3+ messages in thread
From: Vasiliy Kulikov @ 2010-11-26 17:06 UTC (permalink / raw)
To: linux-arm-kernel
clk_get() returns ERR_PTR() on error, not NULL.
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
Cannot compile this driver, so it is not tested at all.
arch/arm/plat-omap/counter_32k.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
index 155fe43..c1e0d00 100644
--- a/arch/arm/plat-omap/counter_32k.c
+++ b/arch/arm/plat-omap/counter_32k.c
@@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
return -ENODEV;
sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
- if (sync_32k_ick)
+ if (!IS_ERR(sync_32k_ick))
clk_enable(sync_32k_ick);
clocksource_32k.mult = clocksource_hz2mult(32768,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
2010-11-26 17:06 [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check Vasiliy Kulikov
@ 2010-11-29 15:29 ` Kevin Hilman
2010-12-06 23:51 ` Tony Lindgren
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2010-11-29 15:29 UTC (permalink / raw)
To: linux-arm-kernel
Vasiliy Kulikov <segoon@openwall.com> writes:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> Cannot compile this driver, so it is not tested at all.
>
> arch/arm/plat-omap/counter_32k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
> index 155fe43..c1e0d00 100644
> --- a/arch/arm/plat-omap/counter_32k.c
> +++ b/arch/arm/plat-omap/counter_32k.c
> @@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
> return -ENODEV;
>
> sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
> - if (sync_32k_ick)
> + if (!IS_ERR(sync_32k_ick))
> clk_enable(sync_32k_ick);
>
> clocksource_32k.mult = clocksource_hz2mult(32768,
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
2010-11-26 17:06 [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check Vasiliy Kulikov
2010-11-29 15:29 ` Kevin Hilman
@ 2010-12-06 23:51 ` Tony Lindgren
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2010-12-06 23:51 UTC (permalink / raw)
To: linux-arm-kernel
* Vasiliy Kulikov <segoon@openwall.com> [101126 08:56]:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> Cannot compile this driver, so it is not tested at all.
Thanks will merge this.
Tony
>
> arch/arm/plat-omap/counter_32k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
> index 155fe43..c1e0d00 100644
> --- a/arch/arm/plat-omap/counter_32k.c
> +++ b/arch/arm/plat-omap/counter_32k.c
> @@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
> return -ENODEV;
>
> sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
> - if (sync_32k_ick)
> + if (!IS_ERR(sync_32k_ick))
> clk_enable(sync_32k_ick);
>
> clocksource_32k.mult = clocksource_hz2mult(32768,
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-06 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-26 17:06 [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check Vasiliy Kulikov
2010-11-29 15:29 ` Kevin Hilman
2010-12-06 23:51 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).