From: lethal@linux-sh.org (Paul Mundt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH (sh-2.6) 1/2] sh: add stack smashing protection support
Date: Wed, 8 Dec 2010 13:40:52 +0900 [thread overview]
Message-ID: <20101208044052.GA31508@linux-sh.org> (raw)
In-Reply-To: <201012071515.25418.vapier@gentoo.org>
On Tue, Dec 07, 2010 at 03:15:23PM -0500, Mike Frysinger wrote:
> On Tuesday, December 07, 2010 05:20:53 Filippo ARCIDIACONO wrote:
> > Add stack smashing suppurt for SH architecture. This is based on work
> > from Nicolas Pitre for ARM (c743f38013aeff58ef6252601e397b5ba281c633).
> > Use the ARM boot_init_stack_canary function to initialize the guard
> > canary. It has been placed under asm-generic to allow archtectures
> > based on __stack_chk_guard to use a common implementation.
> > Update the __stack_chk_guard global variable with the value stored in
> > the task struct whenever a task switch occurs to allow for different
> > canary values per task. This cannot work on SMP where the initial
> > canary value is always used.
> >
> > arch/sh/Kconfig | 13 +++++++++++
> > arch/sh/Makefile | 4 +++
> > arch/sh/include/asm/stackprotector.h | 10 ++++++++
> > arch/sh/kernel/process_32.c | 9 +++++++
> > include/asm-generic/stackprotector.h | 39
>
> if you're starting asm-generic stuff, why not go the distance and do it all in
> common code ? your sh/Kconfig and sh/Makefile changes arent specific to
> SuperH, nor is the symbol in process_32.c.
Indeed. It would be nice to simply shove this in to lib/ with the
Makefile bits in the top-level Makefile.
next prev parent reply other threads:[~2010-12-08 4:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 10:20 [PATCH (sh-2.6) 1/2] sh: add stack smashing protection support Filippo ARCIDIACONO
2010-12-07 10:20 ` [PATCH (sh-2.6) 2/2] arm: use generic implementation of boot_init_stack_canary Filippo ARCIDIACONO
2010-12-07 18:29 ` Nicolas Pitre
2010-12-07 13:43 ` [PATCH (sh-2.6) 1/2] sh: add stack smashing protection support Uwe Kleine-König
2010-12-07 18:28 ` Nicolas Pitre
2010-12-07 20:15 ` Mike Frysinger
2010-12-08 4:40 ` Paul Mundt [this message]
2010-12-09 15:56 ` Carmelo AMOROSO
2010-12-09 16:07 ` Mike Frysinger
2010-12-09 16:45 ` Carmelo AMOROSO
2010-12-09 17:32 ` Mike Frysinger
2010-12-09 18:23 ` Nicolas Pitre
2010-12-09 18:52 ` Carmelo Amoroso
2010-12-09 21:14 ` Mike Frysinger
2010-12-10 5:56 ` Carmelo AMOROSO
2010-12-10 6:38 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208044052.GA31508@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).