From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] support PMIC mc13892
Date: Wed, 8 Dec 2010 11:55:21 +0100 [thread overview]
Message-ID: <20101208105521.GN18244@pengutronix.de> (raw)
In-Reply-To: <20101208100138.GB16418@rakim.wolfsonmicro.main>
Hi Mark,
On Wed, Dec 08, 2010 at 10:01:38AM +0000, Mark Brown wrote:
> On Wed, Dec 08, 2010 at 10:12:26AM +0100, Uwe Kleine-K?nig wrote:
>
> Please cut unneded context - it makes it much easier to find the new
> text in your replies!
hmm, well you could argue here. The downside in this case you stripped
the err_alloc label that might be the right place to place my comment
here. Sometimes I consider it hard what to strip but yes in general I
accede.
> > > + if (ret)
> > > + goto err_alloc;
>
> > err_alloc seems wrong. The goto is taken when reading the revision
> > register fails, not on a failed allocation.
>
> His code is following the style of naming the exit points after what
> needs to be unwound rather than after the place jumped from which is
> common enough?
Then I'd prefer err_free.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-12-08 10:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291778460-22819-1-git-send-email-yong.shen@freescale.com>
2010-12-08 3:21 ` [PATCHv3] support PMIC mc13892 yong.shen at freescale.com
2010-12-08 3:28 ` Yong Shen
2010-12-08 8:52 ` Uwe Kleine-König
2010-12-08 9:02 ` Yong Shen
2010-12-08 12:54 ` Liam Girdwood
2010-12-09 5:13 ` Yong Shen
2010-12-09 9:21 ` Liam Girdwood
2010-12-09 9:42 ` Uwe Kleine-König
2010-12-09 22:33 ` Liam Girdwood
2010-12-08 9:12 ` Uwe Kleine-König
2010-12-08 9:51 ` Yong Shen
2010-12-08 10:01 ` Mark Brown
2010-12-08 10:55 ` Uwe Kleine-König [this message]
2010-12-08 14:26 ` Arnaud Patard (Rtp)
2010-12-08 17:11 ` Mark Brown
2010-12-09 3:27 ` Yong Shen
2010-12-08 9:25 ` Samuel Ortiz
2010-12-08 9:59 ` Yong Shen
2010-12-09 10:25 ` Sascha Hauer
2010-12-09 12:59 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208105521.GN18244@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).