From: ben-i2c@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap -> omap_i2c
Date: Thu, 9 Dec 2010 19:01:10 +0000 [thread overview]
Message-ID: <20101209190110.GR20097@trinity.fluff.org> (raw)
In-Reply-To: <878vzydgxr.fsf@deeprootsystems.com>
On Thu, Dec 09, 2010 at 08:55:28AM -0800, Kevin Hilman wrote:
> Ben,
>
> > The convention for omap device naming is omap_XXX.
> >
> > Rename the device and driver name in order to stick
> > to this naming convention.
Renaming stuff like this is going to have an impact on the userspace
as anyone looking through /sys's driver heirarchy is going to miss the
old name...
It all depends if you really want to go ahead with this...
> > Change device name in clock nodes as well.
> >
> > Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> > c: Paul Walmsley <paul@pwsan.com>
> > Cc: Kevin Hilman <khilman@deeprootsystems.com>
> > Cc: Rajendra Nayak <rnayak@ti.com>
> > Cc: Ben Dooks <ben-i2c@fluff.org>
> > ---
> > arch/arm/mach-omap1/clock_data.c | 6 +++---
> > arch/arm/mach-omap2/clock2420_data.c | 8 ++++----
> > arch/arm/mach-omap2/clock2430_data.c | 8 ++++----
> > arch/arm/mach-omap2/clock3xxx_data.c | 12 ++++++------
> > arch/arm/mach-omap2/clock44xx_data.c | 16 ++++++++--------
> > arch/arm/plat-omap/i2c.c | 2 +-
> > drivers/i2c/busses/i2c-omap.c | 4 ++--
> > 7 files changed, 28 insertions(+), 28 deletions(-)
>
> [...]
>
> > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> > index 760b8be..9d09083 100644
> > --- a/drivers/i2c/busses/i2c-omap.c
> > +++ b/drivers/i2c/busses/i2c-omap.c
> > @@ -1139,7 +1139,7 @@ static struct platform_driver omap_i2c_driver = {
> > .probe = omap_i2c_probe,
> > .remove = omap_i2c_remove,
> > .driver = {
> > - .name = "i2c_omap",
> > + .name = "omap_i2c",
> > .owner = THIS_MODULE,
> > },
> > };
> > @@ -1161,4 +1161,4 @@ module_exit(omap_i2c_exit_driver);
> > MODULE_AUTHOR("MontaVista Software, Inc. (and others)");
> > MODULE_DESCRIPTION("TI OMAP I2C bus adapter");
> > MODULE_LICENSE("GPL");
> > -MODULE_ALIAS("platform:i2c_omap");
> > +MODULE_ALIAS("platform:omap_i2c");
>
> With your ack for the name change in the driver, we can merge this
> through the OMAP tree with the other core changes.
>
> Thanks,
>
> Kevin
>
--
--
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2010-12-09 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 14:24 [PATCH v2 0/2] OMAP: I2C and UART device name cleanup Benoit Cousson
2010-12-09 14:24 ` [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap -> omap_i2c Benoit Cousson
2010-12-09 16:55 ` Kevin Hilman
2010-12-09 19:01 ` Ben Dooks [this message]
2010-12-09 20:46 ` Kevin Hilman
2010-12-09 22:18 ` aaro.koskinen at nokia.com
2010-12-09 22:21 ` Ben Dooks
2010-12-09 23:39 ` Ben Dooks
2010-12-10 8:28 ` Cousson, Benoit
2010-12-18 1:55 ` Tony Lindgren
2010-12-20 16:07 ` Kevin Hilman
2010-12-21 1:34 ` Tony Lindgren
2010-12-09 20:58 ` Ben Dooks
2010-12-09 17:04 ` Paul Walmsley
2010-12-09 14:24 ` [PATCH v2 2/2] OMAP: serial: Change device name: omap-hsuart -> omap_uart Benoit Cousson
2010-12-09 16:56 ` [PATCH v2 0/2] OMAP: I2C and UART device name cleanup Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209190110.GR20097@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).