From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: drop superfluous regulator #ifdef
Date: Fri, 10 Dec 2010 08:12:03 +0000 [thread overview]
Message-ID: <20101210081202.GA19186@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20101210033908.GA4455@void.printf.net>
On Fri, Dec 10, 2010 at 03:39:08AM +0000, Chris Ball wrote:
> Hi Linus,
>
> On Thu, Dec 02, 2010 at 02:36:58PM +0100, Linus Walleij wrote:
> > The regulator and MMC frameworks provide the proper stub functions
> > for the regulator functions anyway, get rid of this.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> > ---
> > drivers/mmc/host/mmci.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> > index 3709ab3..7567872 100644
> > --- a/drivers/mmc/host/mmci.c
> > +++ b/drivers/mmc/host/mmci.c
> > @@ -844,7 +844,6 @@ static int __devinit mmci_probe(struct amba_device *dev, struct amba_id *id)
> > mmc->f_max = min(host->mclk, fmax);
> > dev_dbg(mmc_dev(mmc), "clocking block at %u Hz\n", mmc->f_max);
> >
> > -#ifdef CONFIG_REGULATOR
> > /* If we're using the regulator framework, try to fetch a regulator */
> > host->vcc = regulator_get(&dev->dev, "vmmc");
> > if (IS_ERR(host->vcc))
> > @@ -863,7 +862,7 @@ static int __devinit mmci_probe(struct amba_device *dev, struct amba_id *id)
> > "(using regulator instead)\n");
> > }
> > }
> > -#endif
> > +
> > /* Fall back to platform data if no regulator is found */
> > if (host->vcc == NULL)
> > mmc->ocr_avail = plat->ocr_mask;
>
> Thanks, pushed to mmc-next for .38.
Also queued in the ARM tree.
next prev parent reply other threads:[~2010-12-10 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 13:36 [PATCH] mmci: drop superfluous regulator #ifdef Linus Walleij
2010-12-02 14:02 ` Mark Brown
2010-12-10 3:39 ` Chris Ball
2010-12-10 8:12 ` Russell King - ARM Linux [this message]
2010-12-10 9:30 ` Linus WALLEIJ
2010-12-10 16:07 ` Chris Ball
2010-12-19 16:00 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210081202.GA19186@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).