* [PATCH] mmci: partially revert clock divisor code
@ 2010-12-09 8:52 Linus Walleij
2010-12-10 10:13 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2010-12-09 8:52 UTC (permalink / raw)
To: linux-arm-kernel
I misread the datasheet as if bypass mode was not available at all
on the ux500's, I was wrong. It is there, the datasheet just
states that you should not have to use it.
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
drivers/mmc/host/mmci.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 82880e8..907e582 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -101,13 +101,7 @@ static void mmci_set_clkreg(struct mmci_host *host, unsigned int desired)
if (desired) {
if (desired >= host->mclk) {
- /*
- * The ST clock divider does not like the bypass bit,
- * even though it's available. Instead the datasheet
- * recommends setting the divider to zero.
- */
- if (!variant->st_clkdiv)
- clk = MCI_CLK_BYPASS;
+ clk = MCI_CLK_BYPASS;
host->cclk = host->mclk;
} else if (variant->st_clkdiv) {
/*
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] mmci: partially revert clock divisor code
2010-12-09 8:52 [PATCH] mmci: partially revert clock divisor code Linus Walleij
@ 2010-12-10 10:13 ` Russell King - ARM Linux
2010-12-10 10:41 ` Linus WALLEIJ
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2010-12-10 10:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 09, 2010 at 09:52:55AM +0100, Linus Walleij wrote:
> I misread the datasheet as if bypass mode was not available at all
> on the ux500's, I was wrong. It is there, the datasheet just
> states that you should not have to use it.
Should this be merged with the patch which introduced this change?
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mmci: partially revert clock divisor code
2010-12-10 10:13 ` Russell King - ARM Linux
@ 2010-12-10 10:41 ` Linus WALLEIJ
0 siblings, 0 replies; 3+ messages in thread
From: Linus WALLEIJ @ 2010-12-10 10:41 UTC (permalink / raw)
To: linux-arm-kernel
[Russell]
> On Thu, Dec 09, 2010 at 09:52:55AM +0100, Linus Walleij wrote:
> > I misread the datasheet as if bypass mode was not available at all
> > on the ux500's, I was wrong. It is there, the datasheet just
> > states that you should not have to use it.
>
> Should this be merged with the patch which introduced this change?
If you want to squash them into one, feel free to go ahead. I'm fine
either way.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-10 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 8:52 [PATCH] mmci: partially revert clock divisor code Linus Walleij
2010-12-10 10:13 ` Russell King - ARM Linux
2010-12-10 10:41 ` Linus WALLEIJ
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox