linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] 2.6.37-rc3 massive interactivity regression on ARM
Date: Fri, 10 Dec 2010 16:50:21 +0000	[thread overview]
Message-ID: <20101210165021.GA28263@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1291988866.6803.171.camel@twins>

On Fri, Dec 10, 2010 at 02:47:46PM +0100, Peter Zijlstra wrote:
> 
> Full patch..
> 
> ---
> Subject: sched: Fix the irqtime code to deal with u64 wraps
> From: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Thu Dec 09 14:15:34 CET 2010
> 
> ARM systems have a 32bit sched_clock() [ which needs to be fixed ],
> but this exposed a bug in the irq_time code as well, it doesn't deal
> with wraps at all.
> 
> Fix the irq_time code to deal with u64 wraps by re-writing the code to
> only use delta increments, which avoids the whole issue.
> 
> Furthermore, solve the problem of 32bit arches reading partial updates
> of the u64 time values.
> 
> Cc: Venkatesh Pallipadi <venki@google.com>
> Reported-by: Russell King - ARM Linux <linux@arm.linux.org.uk>

I think credit should go to Mikael Pettersson, who identified the
interactivity regression and problematical commit.  I only pointed
out the dubious nature of the code.

  reply	other threads:[~2010-12-10 16:50 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-27 15:16 [BUG] 2.6.37-rc3 massive interactivity regression on ARM Mikael Pettersson
2010-12-05 12:32 ` Mikael Pettersson
2010-12-05 13:17   ` Russell King - ARM Linux
2010-12-05 14:19     ` Russell King - ARM Linux
2010-12-05 16:07       ` Mikael Pettersson
2010-12-05 16:21         ` Russell King - ARM Linux
2010-12-08 12:40           ` Peter Zijlstra
2010-12-08 12:55             ` Russell King - ARM Linux
2010-12-08 14:04               ` Peter Zijlstra
2010-12-08 14:28                 ` Russell King - ARM Linux
2010-12-08 14:44                   ` Peter Zijlstra
2010-12-08 15:05                     ` Russell King - ARM Linux
2010-12-08 15:43                     ` Linus Walleij
2010-12-08 20:42                     ` john stultz
2010-12-08 23:31                   ` Venkatesh Pallipadi
2010-12-09 12:52                     ` Peter Zijlstra
2010-12-09 17:43                       ` Venkatesh Pallipadi
2010-12-09 17:55                         ` Peter Zijlstra
2010-12-09 18:11                           ` Venkatesh Pallipadi
2010-12-09 18:55                             ` Peter Zijlstra
2010-12-09 22:21                               ` Venkatesh Pallipadi
2010-12-09 23:16                                 ` Peter Zijlstra
2010-12-09 23:35                                   ` Venkatesh Pallipadi
2010-12-10 10:08                                     ` Peter Zijlstra
2010-12-10 13:17                                       ` Peter Zijlstra
2010-12-10 13:27                                         ` Peter Zijlstra
2010-12-10 13:47                                           ` Peter Zijlstra
2010-12-10 16:50                                             ` Russell King - ARM Linux [this message]
2010-12-10 16:54                                               ` Peter Zijlstra
2010-12-10 17:18                                             ` Eric Dumazet
2010-12-10 17:49                                               ` Peter Zijlstra
2010-12-10 18:14                                                 ` Eric Dumazet
2010-12-10 18:39                                                   ` Christoph Lameter
2010-12-10 18:46                                                     ` Peter Zijlstra
2010-12-10 19:51                                                       ` Christoph Lameter
2010-12-10 20:07                                                         ` Peter Zijlstra
2010-12-10 20:23                                                           ` Christoph Lameter
2010-12-10 20:32                                                             ` Peter Zijlstra
2010-12-10 20:39                                                             ` Eric Dumazet
2010-12-10 20:49                                                               ` Eric Dumazet
2010-12-10 21:09                                                                 ` Christoph Lameter
2010-12-10 21:22                                                                   ` Eric Dumazet
2010-12-10 21:45                                                                     ` Christoph Lameter
2010-12-10 17:56                                             ` Russell King - ARM Linux
2010-12-10 18:10                                               ` Peter Zijlstra
2010-12-10 18:43                                                 ` Peter Zijlstra
2010-12-10 19:17                                                 ` Russell King - ARM Linux
2010-12-10 19:37                                                   ` Peter Zijlstra
2010-12-10 19:25                                                 ` Peter Zijlstra
2010-12-13 14:33                             ` Jack Daniel
2010-12-06 21:29       ` Venkatesh Pallipadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101210165021.GA28263@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).