public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: kristoffer.ericson@gmail.com (Kristoffer Ericson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sa1100: Fix platform device registration
Date: Sat, 11 Dec 2010 21:57:11 +0100	[thread overview]
Message-ID: <20101211205710.GB810@boggieman> (raw)
In-Reply-To: <1292090000-21779-1-git-send-email-jochen@scram.de>


Applies and makes sense, so

Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>

On Sat, Dec 11, 2010 at 06:53:20PM +0100, Jochen Friedrich wrote:
> Since commit 7a5b4e16c880f8350d255dc188f81622905618c1, simpad devices don't
> boot anymore, since platform devices are registered too early. Fix by moving
> the registration from map_io to arch_initcall as done on other sa1100 boards.
> 
> Signed-off-by: Jochen Friedrich <jochen@scram.de>
> ---
>  arch/arm/mach-sa1100/simpad.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-sa1100/simpad.c b/arch/arm/mach-sa1100/simpad.c
> index 27692d0..cfb7607 100644
> --- a/arch/arm/mach-sa1100/simpad.c
> +++ b/arch/arm/mach-sa1100/simpad.c
> @@ -166,9 +166,6 @@ static void __init simpad_map_io(void)
>  	PCFR = 0;
>  	PSDR = 0;
>  
> -	sa11x0_register_mtd(&simpad_flash_data, simpad_flash_resources,
> -			      ARRAY_SIZE(simpad_flash_resources));
> -	sa11x0_register_mcp(&simpad_mcp_data);
>  }
>  
>  static void simpad_power_off(void)
> @@ -216,6 +213,10 @@ static int __init simpad_init(void)
>  
>  	pm_power_off = simpad_power_off;
>  
> +	sa11x0_register_mtd(&simpad_flash_data, simpad_flash_resources,
> +			      ARRAY_SIZE(simpad_flash_resources));
> +	sa11x0_register_mcp(&simpad_mcp_data);
> +
>  	ret = platform_add_devices(devices, ARRAY_SIZE(devices));
>  	if(ret)
>  		printk(KERN_WARNING "simpad: Unable to register mq200 framebuffer device");
> -- 
> 1.7.2.3

      reply	other threads:[~2010-12-11 20:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-11 17:53 [PATCH] sa1100: Fix platform device registration Jochen Friedrich
2010-12-11 20:57 ` Kristoffer Ericson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101211205710.GB810@boggieman \
    --to=kristoffer.ericson@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox