linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Allow machine to specify it's own IRQ handlers at run-time
Date: Sun, 12 Dec 2010 14:49:34 +0000	[thread overview]
Message-ID: <20101212144934.GI8665@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTinWANEgSqioEUtR6UcwD7JK1hpXuspKQGqEctko@mail.gmail.com>

On Sun, Dec 12, 2010 at 10:33:01PM +0800, Eric Miao wrote:
> On Wed, Dec 8, 2010 at 9:41 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Tue, Dec 07, 2010 at 09:31:11PM +0800, Eric Miao wrote:
> >> +#ifdef CONFIG_MULTI_IRQ_HANDLER
> >> + ? ? ldr ? ? r1, =handle_arch_irq
> >> + ? ? ldr ? ? r0, [r1]
> >> + ? ? cmp ? ? r0, #0
> >> + ? ? movne ? r0, sp
> >> + ? ? adrne ? lr, BSYM(9997f)
> >> + ? ? ldrne ? pc, [r1]
> >> +#endif
> >
> > You might as well do this:
> > ...

> +#ifdef CONFIG_MULTI_IRQ_HANDLER
> +	ldr	r1, =handle_arch_irq
> +	ldr	r0, [r1]
> +	cmp	r0, #0
> +	movne	r0, sp
> +	adrne	lr, BSYM(9997f)
> +	ldrne	pc, [r1]
> +#endif

This looks suspiciously like the old version to me.

  reply	other threads:[~2010-12-12 14:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22  8:26 [PATCH] ARM: Allow machine to specify it's own IRQ handlers at run-time Eric Miao
2010-12-05  9:23 ` Russell King - ARM Linux
2010-12-06  6:12   ` Eric Miao
2010-12-06  8:06     ` Russell King - ARM Linux
2010-12-06  9:31       ` Eric Miao
2010-12-06 10:11         ` Russell King - ARM Linux
2010-12-07 13:31           ` Eric Miao
2010-12-08 13:41             ` Russell King - ARM Linux
2010-12-12 14:33               ` Eric Miao
2010-12-12 14:49                 ` Russell King - ARM Linux [this message]
2010-12-12 14:50                   ` Eric Miao
2010-12-13  8:45                     ` Eric Miao
2010-12-13 12:55                       ` Magnus Damm
2010-12-12 14:50                 ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101212144934.GI8665@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).