linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Mainline OMAP3 breakage (and other OMAP?)
@ 2010-12-02 21:14 Russell King - ARM Linux
  2010-12-02 21:58 ` Tony Lindgren
  0 siblings, 1 reply; 11+ messages in thread
From: Russell King - ARM Linux @ 2010-12-02 21:14 UTC (permalink / raw)
  To: linux-arm-kernel

This has been around since October:

drivers/video/omap2/vram.c: In function ?omap_vram_reserve_sdram_memblock?:
drivers/video/omap2/vram.c:573: error: ?MEMBLOCK_REAL_LIMIT? undeclared (first use in this function)
drivers/video/omap2/vram.c:573: error: (Each undeclared identifier is reported only once
drivers/video/omap2/vram.c:573: error: for each function it appears in.)

This requires a trivial one-liner compile fix:

diff --git a/drivers/video/omap2/vram.c b/drivers/video/omap2/vram.c
index fed2a72..a8973f0 100644
--- a/drivers/video/omap2/vram.c
+++ b/drivers/video/omap2/vram.c
@@ -570,7 +570,7 @@ void __init omap_vram_reserve_sdram_memblock(void)
 			return;
 		}
 	} else {
-		paddr = memblock_alloc_base(size, PAGE_SIZE, MEMBLOCK_REAL_LIMIT);
+		paddr = memblock_alloc(size, PAGE_SIZE);
 	}
 
 	omap_vram_add_region(paddr, size);

which restores the old behaviour before the X86 memblock changes went
in.  Yes, there may be other changes due to the ioremap stuff, but
that's really no excuse for not fixing the compile error itself.

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2010-12-14 18:55 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-02 21:14 Mainline OMAP3 breakage (and other OMAP?) Russell King - ARM Linux
2010-12-02 21:58 ` Tony Lindgren
2010-12-02 22:16   ` Russell King - ARM Linux
2010-12-02 22:32     ` Tony Lindgren
2010-12-03  3:09       ` Paul Mundt
2010-12-03  8:41         ` Russell King - ARM Linux
2010-12-03 12:10           ` Felipe Contreras
2010-12-03 13:07             ` Russell King - ARM Linux
2010-12-03 13:15               ` Felipe Contreras
2010-12-14 12:23               ` Tomi Valkeinen
2010-12-14 18:55                 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).