From: j.neuschaefer@gmx.net (Jonathan Neuschäfer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch/arm/kernel: use cpu_relax() in halt loops
Date: Tue, 14 Dec 2010 23:48:48 +0100 [thread overview]
Message-ID: <20101214224848.GA1706@debian.debian> (raw)
Looking throught arch/arm/kernel/ I found some halt loops.
I just thought we could save some power here using cpu_relax(),
or am I missing something?
Signed-off-by: Jonathan Neusch?fer <j.neuschaefer@gmx.net>
---
arch/arm/kernel/process.c | 6 ++++--
arch/arm/kernel/setup.c | 7 +++++--
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index e76fcaa..4a83fdf 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -124,7 +124,8 @@ void arm_machine_restart(char mode, const char *cmd)
*/
mdelay(1000);
printk("Reboot failed -- System halted\n");
- while (1);
+ while (1)
+ cpu_relax();
}
/*
@@ -235,7 +236,8 @@ void machine_shutdown(void)
void machine_halt(void)
{
machine_shutdown();
- while (1);
+ while (1)
+ cpu_relax();
}
void machine_power_off(void)
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 336f14e..0d77329 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -41,6 +41,7 @@
#include <asm/cacheflush.h>
#include <asm/cachetype.h>
#include <asm/tlbflush.h>
+#include <asm/processor.h>
#include <asm/mach/arch.h>
#include <asm/mach/irq.h>
@@ -337,7 +338,8 @@ static void __init setup_processor(void)
if (!list) {
printk("CPU configuration botched (ID %08x), unable "
"to continue.\n", read_cpuid_id());
- while (1);
+ while (1)
+ cpu_relax();
}
cpu_name = list->cpu_name;
@@ -434,7 +436,8 @@ static struct machine_desc * __init setup_machine(unsigned int nr)
if (!list) {
printk("Machine configuration botched (nr %d), unable "
"to continue.\n", nr);
- while (1);
+ while (1)
+ cpu_relax();
}
printk("Machine: %s\n", list->name);
--
1.7.2.3
next reply other threads:[~2010-12-14 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 22:48 Jonathan Neuschäfer [this message]
2010-12-14 22:51 ` [PATCH] arch/arm/kernel: use cpu_relax() in halt loops Russell King - ARM Linux
2010-12-14 23:00 ` Jonathan Neuschäfer
-- strict thread matches above, loose matches on Subject: below --
2010-11-27 20:20 Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214224848.GA1706@debian.debian \
--to=j.neuschaefer@gmx.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).