linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] mc13xxx: Add i2c support for mc13xxx-core
Date: Thu, 16 Dec 2010 10:20:32 +0100	[thread overview]
Message-ID: <20101216092032.GA4209@pengutronix.de> (raw)
In-Reply-To: <20101216090210.GE1940@pengutronix.de>

Hi guys,

>      (BTW, did you fix the dependencies?  Currently you need to depend
>      on I2C && SPI.  (Not sure these are the correct names, you may want
>      to double check that.))

Be careful, this is a subtle issue. You will get unresolved symbols if your
chip is connected via SPI, and <driver>=y, SPI=y, together with I2C=m. Been
there.

>      This is more flexible but IMHO not worth the effort.

I had to do it back then :( I wondered if there couldn't be a generic way to
deal with SPI+I2C-drivers, never got to investigate it, though.

Also, be sure to CC i2c- and spi-lists when you do the next version.

Kind regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101216/46476a3c/attachment-0001.sig>

  reply	other threads:[~2010-12-16  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15 21:47 [PATCHv2] mc13xxx: Add i2c support for mc13xxx-core Marc Reilly
2010-12-16  7:47 ` Uwe Kleine-König
2010-12-16  8:30   ` Marc Reilly
2010-12-16  9:02     ` Uwe Kleine-König
2010-12-16  9:20       ` Wolfram Sang [this message]
2010-12-17  6:44         ` Marc Reilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101216092032.GA4209@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).