From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/13] ARM: pxa: convert sched_clock() to use new infrastructure
Date: Thu, 16 Dec 2010 11:05:23 +0100 [thread overview]
Message-ID: <20101216100523.GI1940@pengutronix.de> (raw)
In-Reply-To: <E1PTA8m-00079T-Ce@rmk-PC.arm.linux.org.uk>
Hello Russell,
a very minor nit ...
On Thu, Dec 16, 2010 at 09:28:48AM +0000, Russell King - ARM Linux wrote:
> + return cyc_to_sched_clock(&cd, cyc, (u32)~0);
The value of ~0 is compiler implementation defined, so in general
~((u32)0) is saver. (Though I admit that on arm ~0 will probably always
be -1, still I think using the save construct doesn't hurt here.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-12-16 10:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 9:25 [PATCH 0/13] 64-bit sched_clock Russell King - ARM Linux
2010-12-16 9:27 ` [PATCH 01/13] ARM: sched_clock: provide common infrastructure for sched_clock() Russell King - ARM Linux
2010-12-16 12:52 ` Russell King - ARM Linux
2010-12-16 9:28 ` [PATCH 02/13] ARM: ixp4xx: convert sched_clock() to use new infrastructure Russell King - ARM Linux
2010-12-16 9:28 ` [PATCH 03/13] ARM: mmp: " Russell King - ARM Linux
2010-12-16 9:28 ` [PATCH 04/13] ARM: pxa: " Russell King - ARM Linux
2010-12-16 10:05 ` Uwe Kleine-König [this message]
2010-12-16 10:14 ` Russell King - ARM Linux
2010-12-16 9:29 ` [PATCH 05/13] ARM: sa1100: " Russell King - ARM Linux
2010-12-16 9:29 ` [PATCH 06/13] ARM: tegra: " Russell King - ARM Linux
2010-12-16 9:29 ` [PATCH 07/13] ARM: u300: " Russell King - ARM Linux
2010-12-16 9:30 ` [PATCH 08/13] ARM: iop: " Russell King - ARM Linux
2010-12-16 9:30 ` [PATCH 09/13] ARM: nomadik: " Russell King - ARM Linux
2010-12-16 9:31 ` [PATCH 10/13] ARM: omap: " Russell King - ARM Linux
2010-12-16 9:31 ` [PATCH 11/13] ARM: orion: " Russell King - ARM Linux
2010-12-16 9:31 ` [PATCH 12/13] ARM: versatile: " Russell King - ARM Linux
2010-12-16 9:32 ` [PATCH 13/13] ARM: vexpress: add sched_clock() for Versatile Express Russell King - ARM Linux
2010-12-16 13:04 ` [PATCH 0/13] 64-bit sched_clock Russell King - ARM Linux
2010-12-19 22:23 ` Linus Walleij
2010-12-19 23:39 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216100523.GI1940@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).