[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Kanigeri, Hari]

Hi Tony,

The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
 Linus Torvalds (1):
       Linux 2.6.37-rc4

are available in the git repository at:

 git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38

Felipe Contreras (1):
     OMAP: iommu: make iva2 iommu selectable

Fernando Guzman Lugo (1):
     OMAP: mailbox: change full flag per mailbox queue instead of global

Guzman Lugo, Fernando (4):
     OMAP: iovmm: no gap checking for fixed address
     OMAP: iovmm: add superpages support to fixed da address
     OMAP: iovmm: replace __iounmap with iounmap
     OMAP: iommu: create new api to set valid da range

Kanigeri, Hari (3):
     OMAP: mailbox: fix checkpatch warnings
     OMAP: mailbox: send message in process context
     OMAP: mailbox: add notification support for multiple readers

Omar Ramirez Luna (2):
     OMAP: mailbox: remove unreachable return
     OMAP: mailbox: fix detection for previously supported chips

 arch/arm/mach-omap2/mailbox.c             |   19 +++--
 arch/arm/mach-omap2/omap-iommu.c          |   10 ++-
 arch/arm/plat-omap/Kconfig                |    3 +
 arch/arm/plat-omap/include/plat/iommu.h   |    5 +
 arch/arm/plat-omap/include/plat/mailbox.h |    8 +-
 arch/arm/plat-omap/iommu.c                |   24 +++++
 arch/arm/plat-omap/iovmm.c                |   81 ++++++++++--------
 arch/arm/plat-omap/mailbox.c              |  130 +++++++++++++++++------------
 8 files changed, 179 insertions(+), 101 deletions(-)

The above patch set is dependent on the following 2 Russell's patches.

ARM: io: make iounmap() a simple macro
ARM: io: simplify ioremap* and iounmap definitions
Ref: http://www.spinics.net/lists/linux-omap/msg42023.html

Thank you,
Best regards,
Hari Kanigeri

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Tony Lindgren]

* Kanigeri, Hari <h-kanigeri2@ti.com> [101215 14:48]:
> Hi Tony,
> 
> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>  Linus Torvalds (1):
>        Linux 2.6.37-rc4
> 
> are available in the git repository at:
> 
>  git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
...
 
> The above patch set is dependent on the following 2 Russell's patches.
> 
> ARM: io: make iounmap() a simple macro
> ARM: io: simplify ioremap* and iounmap definitions
> Ref: http://www.spinics.net/lists/linux-omap/msg42023.html

Thanks pulling these in using Russell's io branch as the base.

Regards,

Tony

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Kanigeri, Hari]

Hi Tony,

The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
  Linus Torvalds (1):
        Linux 2.6.37-rc4

are available in the git repository at:

  git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38

Fernando Guzman Lugo (5):
      OMAP: mailbox: change full flag per mailbox queue instead of global
      omap: iovmm - no gap checking for fixed address
      omap: iovmm - add superpages support to fixed da address
      omap: iovmm - replace __iounmap with omap_iounmap
      omap: iommu - create new api to set valid da range

Kanigeri, Hari (3):
      OMAP: mailbox: fix checkpatch warnings
      OMAP: mailbox: send message in process context
      OMAP: mailbox: add notification support for multiple readers

Omar Ramirez Luna (2):
      OMAP: mailbox: remove unreachable return
      OMAP: mailbox: fix detection for previously supported chips

 arch/arm/mach-omap2/mailbox.c             |   19 +++--
 arch/arm/plat-omap/include/plat/iommu.h   |    3 +
 arch/arm/plat-omap/include/plat/mailbox.h |    8 +-
 arch/arm/plat-omap/iommu.c                |   33 +++++++
 arch/arm/plat-omap/iovmm.c                |   84 +++++++++++--------
 arch/arm/plat-omap/mailbox.c              |  130 +++++++++++++++++------------
 6 files changed, 177 insertions(+), 100 deletions(-)

Thank you,
Best regards,
Hari Kanigeri

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Russell King - ARM Linux]

On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
> Hi Tony,
> 
> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>   Linus Torvalds (1):
>         Linux 2.6.37-rc4
> 
> are available in the git repository at:
> 
>   git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
> 
> Fernando Guzman Lugo (5):
>       OMAP: mailbox: change full flag per mailbox queue instead of global
>       omap: iovmm - no gap checking for fixed address
>       omap: iovmm - add superpages support to fixed da address
>       omap: iovmm - replace __iounmap with omap_iounmap

This change is wrong.  Nothing should be directly referencing omap_iounmap
nor for that matter omap_ioremap.  Both are implementation details of the
standard ioremap/iounmap APIs.

Use the official APIs rather than the implementation details behind them.

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Guzman Lugo, Fernando]

On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
>> Hi Tony,
>>
>> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>> ? Linus Torvalds (1):
>> ? ? ? ? Linux 2.6.37-rc4
>>
>> are available in the git repository at:
>>
>> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
>>
>> Fernando Guzman Lugo (5):
>> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
>> ? ? ? omap: iovmm - no gap checking for fixed address
>> ? ? ? omap: iovmm - add superpages support to fixed da address
>> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
>
> This change is wrong. ?Nothing should be directly referencing omap_iounmap
> nor for that matter omap_ioremap. ?Both are implementation details of the
> standard ioremap/iounmap APIs.
>
> Use the official APIs rather than the implementation details behind them.

if you see where the function is used, you will see that it is not
calling the function, it is use as a parameter in unmap_vm_area(), if
I used iounmap which is a macro there I will get a compilation error.
It was already discuss with Hiroshi. The function unmap_vm_area can be
re-implemented after with other patch to avoid receiving such that
parameter, but now it is important resolve the memory leak and the
kernel warning. Also the same was being done before, using __iounmap,
so using function directly behind iounmap was not introduce with my
patch. If you have a better solution please let me know and I will
change the patch.

Thanks,
Fernando.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Russell King - ARM Linux]

On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
> >> Hi Tony,
> >>
> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
> >> ? Linus Torvalds (1):
> >> ? ? ? ? Linux 2.6.37-rc4
> >>
> >> are available in the git repository at:
> >>
> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
> >>
> >> Fernando Guzman Lugo (5):
> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
> >> ? ? ? omap: iovmm - no gap checking for fixed address
> >> ? ? ? omap: iovmm - add superpages support to fixed da address
> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
> >
> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
> > nor for that matter omap_ioremap. ?Both are implementation details of the
> > standard ioremap/iounmap APIs.
> >
> > Use the official APIs rather than the implementation details behind them.
> 
> if you see where the function is used, you will see that it is not
> calling the function, it is use as a parameter in unmap_vm_area(), if
> I used iounmap which is a macro there I will get a compilation error.

Hmm, yes, because iounmap() is defined as a macro rather than iounmap.

The solution to this is to fix iounmap and __arch_iounmap macros so
they aren't macros which take arguments.  That will then allow them
to be used in the way you desire.

diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index 815efa2..91be1f8 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -245,13 +245,13 @@ extern void _memset_io(volatile void __iomem *, int, size_t);
 #define ioremap_nocache(cookie,size)	__arm_ioremap(cookie, size, MT_DEVICE)
 #define ioremap_cached(cookie,size)	__arm_ioremap(cookie, size, MT_DEVICE_CACHED)
 #define ioremap_wc(cookie,size)		__arm_ioremap(cookie, size, MT_DEVICE_WC)
-#define iounmap(cookie)			__iounmap(cookie)
+#define iounmap				__iounmap
 #else
 #define ioremap(cookie,size)		__arch_ioremap((cookie), (size), MT_DEVICE)
 #define ioremap_nocache(cookie,size)	__arch_ioremap((cookie), (size), MT_DEVICE)
 #define ioremap_cached(cookie,size)	__arch_ioremap((cookie), (size), MT_DEVICE_CACHED)
 #define ioremap_wc(cookie,size)		__arch_ioremap((cookie), (size), MT_DEVICE_WC)
-#define iounmap(cookie)			__arch_iounmap(cookie)
+#define iounmap				__arch_iounmap
 #endif
 
 /*
diff --git a/arch/arm/plat-omap/include/plat/io.h b/arch/arm/plat-omap/include/plat/io.h
index 128b549..204865f 100644
--- a/arch/arm/plat-omap/include/plat/io.h
+++ b/arch/arm/plat-omap/include/plat/io.h
@@ -294,8 +294,8 @@ static inline void omap44xx_map_common_io(void)
 extern void omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
 				 struct omap_sdrc_params *sdrc_cs1);
 
-#define __arch_ioremap(p,s,t)	omap_ioremap(p,s,t)
-#define __arch_iounmap(v)	omap_iounmap(v)
+#define __arch_ioremap	omap_ioremap
+#define __arch_iounmap	omap_iounmap
 
 void __iomem *omap_ioremap(unsigned long phys, size_t size, unsigned int type);
 void omap_iounmap(volatile void __iomem *addr);

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Guzman Lugo, Fernando]

On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
>> >> Hi Tony,
>> >>
>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>> >> ? Linus Torvalds (1):
>> >> ? ? ? ? Linux 2.6.37-rc4
>> >>
>> >> are available in the git repository at:
>> >>
>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
>> >>
>> >> Fernando Guzman Lugo (5):
>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
>> >> ? ? ? omap: iovmm - no gap checking for fixed address
>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
>> >
>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
>> > nor for that matter omap_ioremap. ?Both are implementation details of the
>> > standard ioremap/iounmap APIs.
>> >
>> > Use the official APIs rather than the implementation details behind them.
>>
>> if you see where the function is used, you will see that it is not
>> calling the function, it is use as a parameter in unmap_vm_area(), if
>> I used iounmap which is a macro there I will get a compilation error.
>
> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
>
> The solution to this is to fix iounmap and __arch_iounmap macros so
> they aren't macros which take arguments. ?That will then allow them
> to be used in the way you desire.

yes, that way it can be used in the function parameter. what is the
right thing to do?
1) You send your patch and then I send the new version of the patches.
2) I make a new series of the patches with the change to iounmap and I
include your patch in the series.


Thanks,
Fernando.

>
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index 815efa2..91be1f8 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
> @@ -245,13 +245,13 @@ extern void _memset_io(volatile void __iomem *, int, size_t);
> ?#define ioremap_nocache(cookie,size) ? __arm_ioremap(cookie, size, MT_DEVICE)
> ?#define ioremap_cached(cookie,size) ? ?__arm_ioremap(cookie, size, MT_DEVICE_CACHED)
> ?#define ioremap_wc(cookie,size) ? ? ? ? ? ? ? ?__arm_ioremap(cookie, size, MT_DEVICE_WC)
> -#define iounmap(cookie) ? ? ? ? ? ? ? ? ? ? ? ?__iounmap(cookie)
> +#define iounmap ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?__iounmap
> ?#else
> ?#define ioremap(cookie,size) ? ? ? ? ? __arch_ioremap((cookie), (size), MT_DEVICE)
> ?#define ioremap_nocache(cookie,size) ? __arch_ioremap((cookie), (size), MT_DEVICE)
> ?#define ioremap_cached(cookie,size) ? ?__arch_ioremap((cookie), (size), MT_DEVICE_CACHED)
> ?#define ioremap_wc(cookie,size) ? ? ? ? ? ? ? ?__arch_ioremap((cookie), (size), MT_DEVICE_WC)
> -#define iounmap(cookie) ? ? ? ? ? ? ? ? ? ? ? ?__arch_iounmap(cookie)
> +#define iounmap ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?__arch_iounmap
> ?#endif
>
> ?/*
> diff --git a/arch/arm/plat-omap/include/plat/io.h b/arch/arm/plat-omap/include/plat/io.h
> index 128b549..204865f 100644
> --- a/arch/arm/plat-omap/include/plat/io.h
> +++ b/arch/arm/plat-omap/include/plat/io.h
> @@ -294,8 +294,8 @@ static inline void omap44xx_map_common_io(void)
> ?extern void omap2_init_common_hw(struct omap_sdrc_params *sdrc_cs0,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? struct omap_sdrc_params *sdrc_cs1);
>
> -#define __arch_ioremap(p,s,t) ?omap_ioremap(p,s,t)
> -#define __arch_iounmap(v) ? ? ?omap_iounmap(v)
> +#define __arch_ioremap omap_ioremap
> +#define __arch_iounmap omap_iounmap
>
> ?void __iomem *omap_ioremap(unsigned long phys, size_t size, unsigned int type);
> ?void omap_iounmap(volatile void __iomem *addr);
>

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Kanigeri, Hari]

Ruseell,

On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
<fernando.lugo@ti.com> wrote:
> On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
>>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
>>> <linux@arm.linux.org.uk> wrote:
>>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
>>> >> Hi Tony,
>>> >>
>>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>>> >> ? Linus Torvalds (1):
>>> >> ? ? ? ? Linux 2.6.37-rc4
>>> >>
>>> >> are available in the git repository at:
>>> >>
>>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
>>> >>
>>> >> Fernando Guzman Lugo (5):
>>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
>>> >> ? ? ? omap: iovmm - no gap checking for fixed address
>>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
>>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
>>> >
>>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
>>> > nor for that matter omap_ioremap. ?Both are implementation details of the
>>> > standard ioremap/iounmap APIs.
>>> >
>>> > Use the official APIs rather than the implementation details behind them.
>>>
>>> if you see where the function is used, you will see that it is not
>>> calling the function, it is use as a parameter in unmap_vm_area(), if
>>> I used iounmap which is a macro there I will get a compilation error.
>>
>> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
>>
>> The solution to this is to fix iounmap and __arch_iounmap macros so
>> they aren't macros which take arguments. ?That will then allow them
>> to be used in the way you desire.
>
> yes, that way it can be used in the function parameter. what is the
> right thing to do?
> 1) You send your patch and then I send the new version of the patches.
> 2) I make a new series of the patches with the change to iounmap and I
> include your patch in the series.
>

Can you please suggest the approach we take here ? So, either you send
your suggested change as a patch and Fernando's patch will be based on
it, or he can take a TODO action item to patch again if you plan to
send this change later.


Thank you,
Best regards,
Hari Kanigeri

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Russell King - ARM Linux]

On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote:
> Ruseell,
> 
> On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
> <fernando.lugo@ti.com> wrote:
> > On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> >> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
> >>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
> >>> <linux@arm.linux.org.uk> wrote:
> >>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
> >>> >> Hi Tony,
> >>> >>
> >>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
> >>> >> ? Linus Torvalds (1):
> >>> >> ? ? ? ? Linux 2.6.37-rc4
> >>> >>
> >>> >> are available in the git repository at:
> >>> >>
> >>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
> >>> >>
> >>> >> Fernando Guzman Lugo (5):
> >>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
> >>> >> ? ? ? omap: iovmm - no gap checking for fixed address
> >>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
> >>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
> >>> >
> >>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
> >>> > nor for that matter omap_ioremap. ?Both are implementation details of the
> >>> > standard ioremap/iounmap APIs.
> >>> >
> >>> > Use the official APIs rather than the implementation details behind them.
> >>>
> >>> if you see where the function is used, you will see that it is not
> >>> calling the function, it is use as a parameter in unmap_vm_area(), if
> >>> I used iounmap which is a macro there I will get a compilation error.
> >>
> >> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
> >>
> >> The solution to this is to fix iounmap and __arch_iounmap macros so
> >> they aren't macros which take arguments. ?That will then allow them
> >> to be used in the way you desire.
> >
> > yes, that way it can be used in the function parameter. what is the
> > right thing to do?
> > 1) You send your patch and then I send the new version of the patches.
> > 2) I make a new series of the patches with the change to iounmap and I
> > include your patch in the series.
> >
> 
> Can you please suggest the approach we take here ? So, either you send
> your suggested change as a patch and Fernando's patch will be based on
> it, or he can take a TODO action item to patch again if you plan to
> send this change later.

I've not yet decided myself what to do about it, which is why I haven't
replied or even committed the patch myself - I've had the hotplug/SMP/gic
stuff to concentrate on during the latter half of last week _and_ the
weekend, so I've not had time to get back to this yet.

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Russell King - ARM Linux]

On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote:
> Ruseell,
> 
> On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
> <fernando.lugo@ti.com> wrote:
> > On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> >> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
> >>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
> >>> <linux@arm.linux.org.uk> wrote:
> >>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
> >>> >> Hi Tony,
> >>> >>
> >>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
> >>> >> ? Linus Torvalds (1):
> >>> >> ? ? ? ? Linux 2.6.37-rc4
> >>> >>
> >>> >> are available in the git repository at:
> >>> >>
> >>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
> >>> >>
> >>> >> Fernando Guzman Lugo (5):
> >>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
> >>> >> ? ? ? omap: iovmm - no gap checking for fixed address
> >>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
> >>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
> >>> >
> >>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
> >>> > nor for that matter omap_ioremap. ?Both are implementation details of the
> >>> > standard ioremap/iounmap APIs.
> >>> >
> >>> > Use the official APIs rather than the implementation details behind them.
> >>>
> >>> if you see where the function is used, you will see that it is not
> >>> calling the function, it is use as a parameter in unmap_vm_area(), if
> >>> I used iounmap which is a macro there I will get a compilation error.
> >>
> >> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
> >>
> >> The solution to this is to fix iounmap and __arch_iounmap macros so
> >> they aren't macros which take arguments. ?That will then allow them
> >> to be used in the way you desire.
> >
> > yes, that way it can be used in the function parameter. what is the
> > right thing to do?
> > 1) You send your patch and then I send the new version of the patches.
> > 2) I make a new series of the patches with the change to iounmap and I
> > include your patch in the series.
> >
> 
> Can you please suggest the approach we take here ? So, either you send
> your suggested change as a patch and Fernando's patch will be based on
> it, or he can take a TODO action item to patch again if you plan to
> send this change later.

Right, the patches are in my git tree, under the 'io' branch:

 http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git io

which you can use to base stuff off of.  Make sure your tree has commits
up to 2.6.37-rc5 before pulling to avoid grabbing MB's of pack files.

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Kanigeri, Hari]

On Sun, Dec 12, 2010 at 5:20 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote:
>> Ruseell,
>>
>> On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
>> <fernando.lugo@ti.com> wrote:
>> > On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
>> > <linux@arm.linux.org.uk> wrote:
>> >> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
>> >>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
>> >>> <linux@arm.linux.org.uk> wrote:
>> >>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
>> >>> >> Hi Tony,
>> >>> >>
>> >>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>> >>> >> ? Linus Torvalds (1):
>> >>> >> ? ? ? ? Linux 2.6.37-rc4
>> >>> >>
>> >>> >> are available in the git repository at:
>> >>> >>
>> >>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
>> >>> >>
>> >>> >> Fernando Guzman Lugo (5):
>> >>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
>> >>> >> ? ? ? omap: iovmm - no gap checking for fixed address
>> >>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
>> >>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
>> >>> >
>> >>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
>> >>> > nor for that matter omap_ioremap. ?Both are implementation details of the
>> >>> > standard ioremap/iounmap APIs.
>> >>> >
>> >>> > Use the official APIs rather than the implementation details behind them.
>> >>>
>> >>> if you see where the function is used, you will see that it is not
>> >>> calling the function, it is use as a parameter in unmap_vm_area(), if
>> >>> I used iounmap which is a macro there I will get a compilation error.
>> >>
>> >> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
>> >>
>> >> The solution to this is to fix iounmap and __arch_iounmap macros so
>> >> they aren't macros which take arguments. ?That will then allow them
>> >> to be used in the way you desire.
>> >
>> > yes, that way it can be used in the function parameter. what is the
>> > right thing to do?
>> > 1) You send your patch and then I send the new version of the patches.
>> > 2) I make a new series of the patches with the change to iounmap and I
>> > include your patch in the series.
>> >
>>
>> Can you please suggest the approach we take here ? So, either you send
>> your suggested change as a patch and Fernando's patch will be based on
>> it, or he can take a TODO action item to patch again if you plan to
>> send this change later.
>
> Right, the patches are in my git tree, under the 'io' branch:
>
> ?http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git io
>
> which you can use to base stuff off of. ?Make sure your tree has commits
> up to 2.6.37-rc5 before pulling to avoid grabbing MB's of pack files.
>


Thanks, Russell.

Fernando, can you please rebase your patches based on Russell's patch.
I will take care of queuing up the patches for git pull request.


Thank you,
Best regards,
Hari Kanigeri

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Guzman Lugo, Fernando]

On Mon, Dec 13, 2010 at 11:31 AM, Kanigeri, Hari <h-kanigeri2@ti.com> wrote:
> On Sun, Dec 12, 2010 at 5:20 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote:
>>> Ruseell,
>>>
>>> On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
>>> <fernando.lugo@ti.com> wrote:
>>> > On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
>>> > <linux@arm.linux.org.uk> wrote:
>>> >> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
>>> >>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
>>> >>> <linux@arm.linux.org.uk> wrote:
>>> >>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
>>> >>> >> Hi Tony,
>>> >>> >>
>>> >>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>>> >>> >> ? Linus Torvalds (1):
>>> >>> >> ? ? ? ? Linux 2.6.37-rc4
>>> >>> >>
>>> >>> >> are available in the git repository at:
>>> >>> >>
>>> >>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
>>> >>> >>
>>> >>> >> Fernando Guzman Lugo (5):
>>> >>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
>>> >>> >> ? ? ? omap: iovmm - no gap checking for fixed address
>>> >>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
>>> >>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
>>> >>> >
>>> >>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
>>> >>> > nor for that matter omap_ioremap. ?Both are implementation details of the
>>> >>> > standard ioremap/iounmap APIs.
>>> >>> >
>>> >>> > Use the official APIs rather than the implementation details behind them.
>>> >>>
>>> >>> if you see where the function is used, you will see that it is not
>>> >>> calling the function, it is use as a parameter in unmap_vm_area(), if
>>> >>> I used iounmap which is a macro there I will get a compilation error.
>>> >>
>>> >> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
>>> >>
>>> >> The solution to this is to fix iounmap and __arch_iounmap macros so
>>> >> they aren't macros which take arguments. ?That will then allow them
>>> >> to be used in the way you desire.
>>> >
>>> > yes, that way it can be used in the function parameter. what is the
>>> > right thing to do?
>>> > 1) You send your patch and then I send the new version of the patches.
>>> > 2) I make a new series of the patches with the change to iounmap and I
>>> > include your patch in the series.
>>> >
>>>
>>> Can you please suggest the approach we take here ? So, either you send
>>> your suggested change as a patch and Fernando's patch will be based on
>>> it, or he can take a TODO action item to patch again if you plan to
>>> send this change later.
>>
>> Right, the patches are in my git tree, under the 'io' branch:
>>
>> ?http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git io


I tried to clone it but after sometime it fails, I tried to used
git:// but it did not work and know behind a http proxy it is getting
"The requested URL returned error: 500" do someone know if I need
something special to clone it?

Regards,
Fernando.

>>
>> which you can use to base stuff off of. ?Make sure your tree has commits
>> up to 2.6.37-rc5 before pulling to avoid grabbing MB's of pack files.
>>
>
>
> Thanks, Russell.
>
> Fernando, can you please rebase your patches based on Russell's patch.
> I will take care of queuing up the patches for git pull request.
>
>
> Thank you,
> Best regards,
> Hari Kanigeri
>

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Russell King - ARM Linux]

On Mon, Dec 13, 2010 at 05:02:12PM -0600, Guzman Lugo, Fernando wrote:
> On Mon, Dec 13, 2010 at 11:31 AM, Kanigeri, Hari <h-kanigeri2@ti.com> wrote:
> > On Sun, Dec 12, 2010 at 5:20 AM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> >> On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote:
> >>> Ruseell,
> >>>
> >>> On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
> >>> <fernando.lugo@ti.com> wrote:
> >>> > On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
> >>> > <linux@arm.linux.org.uk> wrote:
> >>> >> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
> >>> >>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
> >>> >>> <linux@arm.linux.org.uk> wrote:
> >>> >>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
> >>> >>> >> Hi Tony,
> >>> >>> >>
> >>> >>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
> >>> >>> >> ? Linus Torvalds (1):
> >>> >>> >> ? ? ? ? Linux 2.6.37-rc4
> >>> >>> >>
> >>> >>> >> are available in the git repository at:
> >>> >>> >>
> >>> >>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
> >>> >>> >>
> >>> >>> >> Fernando Guzman Lugo (5):
> >>> >>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
> >>> >>> >> ? ? ? omap: iovmm - no gap checking for fixed address
> >>> >>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
> >>> >>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
> >>> >>> >
> >>> >>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
> >>> >>> > nor for that matter omap_ioremap. ?Both are implementation details of the
> >>> >>> > standard ioremap/iounmap APIs.
> >>> >>> >
> >>> >>> > Use the official APIs rather than the implementation details behind them.
> >>> >>>
> >>> >>> if you see where the function is used, you will see that it is not
> >>> >>> calling the function, it is use as a parameter in unmap_vm_area(), if
> >>> >>> I used iounmap which is a macro there I will get a compilation error.
> >>> >>
> >>> >> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
> >>> >>
> >>> >> The solution to this is to fix iounmap and __arch_iounmap macros so
> >>> >> they aren't macros which take arguments. ?That will then allow them
> >>> >> to be used in the way you desire.
> >>> >
> >>> > yes, that way it can be used in the function parameter. what is the
> >>> > right thing to do?
> >>> > 1) You send your patch and then I send the new version of the patches.
> >>> > 2) I make a new series of the patches with the change to iounmap and I
> >>> > include your patch in the series.
> >>> >
> >>>
> >>> Can you please suggest the approach we take here ? So, either you send
> >>> your suggested change as a patch and Fernando's patch will be based on
> >>> it, or he can take a TODO action item to patch again if you plan to
> >>> send this change later.
> >>
> >> Right, the patches are in my git tree, under the 'io' branch:
> >>
> >> ?http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git io
> 
> 
> I tried to clone it but after sometime it fails, I tried to used
> git:// but it did not work and know behind a http proxy it is getting
> "The requested URL returned error: 500" do someone know if I need
> something special to clone it?

Sigh.

Someone has helpfully upgraded apache on the machine at about 8pm, but
failed to check that it was running afterwards (it's now midnight.)

I've just restarted it, so it should work now.

[GIT PULL] OMAP: mailbox and iommu changes: for-next for v2.6.38

[Guzman Lugo, Fernando]

On Mon, Dec 13, 2010 at 6:02 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Dec 13, 2010 at 05:02:12PM -0600, Guzman Lugo, Fernando wrote:
>> On Mon, Dec 13, 2010 at 11:31 AM, Kanigeri, Hari <h-kanigeri2@ti.com> wrote:
>> > On Sun, Dec 12, 2010 at 5:20 AM, Russell King - ARM Linux
>> > <linux@arm.linux.org.uk> wrote:
>> >> On Mon, Dec 06, 2010 at 09:16:23AM -0600, Kanigeri, Hari wrote:
>> >>> Ruseell,
>> >>>
>> >>> On Thu, Dec 2, 2010 at 9:43 AM, Guzman Lugo, Fernando
>> >>> <fernando.lugo@ti.com> wrote:
>> >>> > On Thu, Dec 2, 2010 at 9:20 AM, Russell King - ARM Linux
>> >>> > <linux@arm.linux.org.uk> wrote:
>> >>> >> On Thu, Dec 02, 2010 at 08:50:07AM -0600, Guzman Lugo, Fernando wrote:
>> >>> >>> On Thu, Dec 2, 2010 at 6:33 AM, Russell King - ARM Linux
>> >>> >>> <linux@arm.linux.org.uk> wrote:
>> >>> >>> > On Thu, Dec 02, 2010 at 06:07:23AM -0600, Kanigeri, Hari wrote:
>> >>> >>> >> Hi Tony,
>> >>> >>> >>
>> >>> >>> >> The following changes since commit e8a7e48bb248a1196484d3f8afa53bded2b24e71:
>> >>> >>> >> ? Linus Torvalds (1):
>> >>> >>> >> ? ? ? ? Linux 2.6.37-rc4
>> >>> >>> >>
>> >>> >>> >> are available in the git repository at:
>> >>> >>> >>
>> >>> >>> >> ? git://gitorious.org/iommu_mailbox/iommu_mailbox.git for_2.6.38
>> >>> >>> >>
>> >>> >>> >> Fernando Guzman Lugo (5):
>> >>> >>> >> ? ? ? OMAP: mailbox: change full flag per mailbox queue instead of global
>> >>> >>> >> ? ? ? omap: iovmm - no gap checking for fixed address
>> >>> >>> >> ? ? ? omap: iovmm - add superpages support to fixed da address
>> >>> >>> >> ? ? ? omap: iovmm - replace __iounmap with omap_iounmap
>> >>> >>> >
>> >>> >>> > This change is wrong. ?Nothing should be directly referencing omap_iounmap
>> >>> >>> > nor for that matter omap_ioremap. ?Both are implementation details of the
>> >>> >>> > standard ioremap/iounmap APIs.
>> >>> >>> >
>> >>> >>> > Use the official APIs rather than the implementation details behind them.
>> >>> >>>
>> >>> >>> if you see where the function is used, you will see that it is not
>> >>> >>> calling the function, it is use as a parameter in unmap_vm_area(), if
>> >>> >>> I used iounmap which is a macro there I will get a compilation error.
>> >>> >>
>> >>> >> Hmm, yes, because iounmap() is defined as a macro rather than iounmap.
>> >>> >>
>> >>> >> The solution to this is to fix iounmap and __arch_iounmap macros so
>> >>> >> they aren't macros which take arguments. ?That will then allow them
>> >>> >> to be used in the way you desire.
>> >>> >
>> >>> > yes, that way it can be used in the function parameter. what is the
>> >>> > right thing to do?
>> >>> > 1) You send your patch and then I send the new version of the patches.
>> >>> > 2) I make a new series of the patches with the change to iounmap and I
>> >>> > include your patch in the series.
>> >>> >
>> >>>
>> >>> Can you please suggest the approach we take here ? So, either you send
>> >>> your suggested change as a patch and Fernando's patch will be based on
>> >>> it, or he can take a TODO action item to patch again if you plan to
>> >>> send this change later.
>> >>
>> >> Right, the patches are in my git tree, under the 'io' branch:
>> >>
>> >> ?http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git io
>>
>>
>> I tried to clone it but after sometime it fails, I tried to used
>> git:// but it did not work and know behind a http proxy it is getting
>> "The requested URL returned error: 500" do someone know if I need
>> something special to clone it?
>
> Sigh.
>
> Someone has helpfully upgraded apache on the machine at about 8pm, but
> failed to check that it was running afterwards (it's now midnight.)
>
> I've just restarted it, so it should work now.

Thanks it is working now :).

Regards,
Fernando.

>