From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sat, 18 Dec 2010 17:36:24 +0000 Subject: [PATCH 2/6] OMAP4: Pandaboard: Add omap_reserve functionality In-Reply-To: <20101218172055.GT5941@atomide.com> References: <20101218030406.10251.73118.stgit@baageli.muru.com> <20101218030521.10251.89993.stgit@baageli.muru.com> <20101218082703.GB3047@n2100.arm.linux.org.uk> <20101218172055.GT5941@atomide.com> Message-ID: <20101218173624.GD3047@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Dec 18, 2010 at 09:20:56AM -0800, Tony Lindgren wrote: > * Russell King - ARM Linux [101218 00:26]: > > On Fri, Dec 17, 2010 at 07:05:21PM -0800, Tony Lindgren wrote: > > > /* Maintainer: David Anders - Texas Instruments Inc */ > > > .boot_params = 0x80000100, > > > .map_io = omap4_panda_map_io, > > > + .reserve = omap_reserve, > > > > Please put .reserve before .map_io. > > Hmm, that's the way it should be.. But we should also correct the > earlier changes too? Strangely that's what I've been doing in my init_early patches. My comment was aimed to ensure that no new instances are introduced.