linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] ARM: U8500 core machine support
Date: Sun, 19 Dec 2010 11:09:13 +0000	[thread overview]
Message-ID: <20101219110913.GA23979@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1259279756.13327.72.camel@vinay-desktop>

... going back to this patch...

On Fri, Nov 27, 2009 at 05:25:56AM +0530, srinidhi kasagar wrote:
> +/*
> + * U8500 specific entry point for secondary CPUs.
> + */
> +ENTRY(u8500_secondary_startup)
> +	mrc	p15, 0, r0, c0, c0, 5
> +	and	r0, r0, #15
> +	adr	r4, 1f
> +	ldmia	r4, {r5, r6}
> +	sub	r4, r4, r5
> +	add	r6, r6, r4
> +	dsb

Can you please explain why you added a dsb here, whereas most other
platforms don't require it?

> +pen:	ldr	r7, [r6]
> +	cmp	r7, r0
> +	bne	pen
> +
> +	/*
> +	 * we've been released from the holding pen: secondary_stack
> +	 * should now contain the SVC stack for this core
> +	 */
> +	b	secondary_startup
> +
> +1:	.long	.
> +	.long	pen_release

  reply	other threads:[~2010-12-19 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26 23:55 [PATCH v4 3/6] ARM: U8500 core machine support srinidhi kasagar
2010-12-19 11:09 ` Russell King - ARM Linux [this message]
2010-12-20  4:47   ` Srinidhi KASAGAR
2010-12-20 17:08     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101219110913.GA23979@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).