From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: drop superfluous regulator #ifdef
Date: Sun, 19 Dec 2010 16:00:59 +0000 [thread overview]
Message-ID: <20101219160059.GP9937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1291297018-3074-1-git-send-email-linus.walleij@stericsson.com>
On Thu, Dec 02, 2010 at 02:36:58PM +0100, Linus Walleij wrote:
> The regulator and MMC frameworks provide the proper stub functions
> for the regulator functions anyway, get rid of this.
I'm dropping this patch - it's wrong, because on platforms without
regulator support, it stamps over the provided platform values:
mmci-pl18x mb:mmci: Provided ocr_mask/setpower will not be used (using regulator instead)
# CONFIG_REGULATOR is not set
So the ifdefs have to stay until some other solution for this is found.
Maybe the:
if (IS_ERR(host->vcc))
host->vcc = NULL;
else {
should be:
if (IS_ERR(host->vcc) || host->vcc == NULL)
host->vcc = NULL;
else {
or maybe:
if (IS_ERR(host->vcc))
host->vcc = NULL;
else if (host->vcc) {
prev parent reply other threads:[~2010-12-19 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 13:36 [PATCH] mmci: drop superfluous regulator #ifdef Linus Walleij
2010-12-02 14:02 ` Mark Brown
2010-12-10 3:39 ` Chris Ball
2010-12-10 8:12 ` Russell King - ARM Linux
2010-12-10 9:30 ` Linus WALLEIJ
2010-12-10 16:07 ` Chris Ball
2010-12-19 16:00 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101219160059.GP9937@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).