From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 05/15] ARM: mxs: Add low-level debug UART support
Date: Mon, 20 Dec 2010 21:22:01 +0800 [thread overview]
Message-ID: <20101220132147.GB16497@freescale.com> (raw)
In-Reply-To: <20101220115059.GA8885@pengutronix.de>
On Mon, Dec 20, 2010 at 12:50:59PM +0100, Wolfram Sang wrote:
> Hi Shawn,
>
> I discovered this weekend that the DUART is just an amba-pl011 which
> is already supported in mainline. So we should use the existing
> infrastructure here.
>
> On Sat, Dec 18, 2010 at 09:39:29PM +0800, Shawn Guo wrote:
>
> > - DEBUG_LL support, which is incompatible with multi-soc MXS image
> > because of different DUART base address on MX23 and MX28
>
> We should be able to use the AMBA identification signature to distinguish at
> runtime, no?
>
> > - uncompress message support
> >
> > Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
>
> > arch/arm/mach-mxs/include/mach/debug-macro.S | 52 ++++++++++++++++++
>
> We should use asm/hardware/debug-pl01x.S, like the other users:
>
> wsa at katana:~/Kernel/linux-2.6/arch/arm$ g debug-pl01x
> include/asm/hardware/debug-pl01x.S:1:/* arch/arm/include/asm/hardware/debug-pl01x.S
> mach-cns3xxx/include/mach/debug-macro.S:19:#include <asm/hardware/debug-pl01x.S>
> mach-ep93xx/include/mach/debug-macro.S:21:#include <asm/hardware/debug-pl01x.S>
> mach-integrator/include/mach/debug-macro.S:20:#include <asm/hardware/debug-pl01x.S>
> mach-nomadik/include/mach/debug-macro.S:20:#include <asm/hardware/debug-pl01x.S>
> mach-realview/include/mach/debug-macro.S:42:#include <asm/hardware/debug-pl01x.S>
> mach-u300/include/mach/debug-macro.S:21:#include <asm/hardware/debug-pl01x.S>
> mach-ux500/include/mach/debug-macro.S:26:#include <asm/hardware/debug-pl01x.S>
> mach-versatile/include/mach/debug-macro.S:21:#include <asm/hardware/debug-pl01x.S>
> mach-vexpress/include/mach/debug-macro.S:21:#include <asm/hardware/debug-pl01x.S>
>
Just tested it, and it works. Will do in v8. Thanks for the comment.
>
> > arch/arm/mach-mxs/include/mach/uncompress.h | 76 ++++++++++++++++++++++++++
>
> Auto-detection could be used here, too?
>
I'm afraid not. How do you expect the detection is done, by reading
some register like we are doing in system.c? Which register
specifically? If the register gets different address between
mx23 and mx28, we need to utilize the current mechanism to
distinguish the address anyway.
--
Regards,
Shawn
next prev parent reply other threads:[~2010-12-20 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 13:39 [PATCH v7 00/15] ARM: mxs: Add initial support for MX23 and MX28 Shawn Guo
2010-12-18 13:39 ` [PATCH v7 03/15] ARM: mxs: Add reset routines Shawn Guo
2010-12-18 13:39 ` [PATCH v7 04/15] ARM: mxs: Add interrupt support Shawn Guo
2010-12-18 13:39 ` [PATCH v7 05/15] ARM: mxs: Add low-level debug UART support Shawn Guo
2010-12-20 11:50 ` Wolfram Sang
2010-12-20 13:22 ` Shawn Guo [this message]
2010-12-20 13:55 ` Wolfram Sang
2010-12-20 14:25 ` Shawn Guo
2010-12-20 14:35 ` Wolfram Sang
2010-12-18 13:39 ` [PATCH v7 06/15] ARM: mxs: Add timer support Shawn Guo
2010-12-18 13:39 ` [PATCH v7 07/15] ARM: mxs: Add gpio support Shawn Guo
2010-12-18 13:39 ` [PATCH v7 08/15] ARM: mxs: Add iomux support Shawn Guo
2010-12-20 9:44 ` Uwe Kleine-König
2010-12-18 13:39 ` [PATCH v7 09/15] ARM: mxs: Add clock support Shawn Guo
2010-12-18 13:39 ` [PATCH v7 13/15] ARM: mxs: Add initial mx23evk support Shawn Guo
2010-12-20 9:48 ` Uwe Kleine-König
2010-12-20 10:17 ` Shawn Guo
2010-12-18 13:39 ` [PATCH v7 14/15] ARM: mxs: Add initial mx28evk support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220132147.GB16497@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).