From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: convert dma-mapping to asm-generic API
Date: Tue, 21 Dec 2010 10:36:52 +0000 [thread overview]
Message-ID: <20101221103652.GL28157@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1292926802-12326-1-git-send-email-jamie@jamieiles.com>
On Tue, Dec 21, 2010 at 10:20:01AM +0000, Jamie Iles wrote:
> Note: this patch also requires "ARM: dmabounce: fix partial sync in
> dma_sync_single_* API" from FUJITA Tomonori:
>
> http://www.spinics.net/lists/netdev/msg126826.html
>
> which allows us to do fuzzy matching of the buffers when using
> dmabounce.
Which I've already said no to.
I don't believe that the direction taken there is anywhere near the right
one - the approach we have (implementing the whole buffer sync in terms
of the partial buffer sync) is the far more logical, simpler and safer
way, and doesn't lead to the possibility of two partially overlapping
mappings causing the wrong one to be operated upon.
The debug code doesn't check for overlapping mappings in any way, so we
can't say that they never occur.
With the way that the DMA API has gone, I view the "generic" stuff as
a disaster.
next prev parent reply other threads:[~2010-12-21 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 10:20 [PATCH 1/2] ARM: convert dma-mapping to asm-generic API Jamie Iles
2010-12-21 10:20 ` [PATCH 2/2] ARM: use cached memory in dma_alloc_coherent() if possible Jamie Iles
2010-12-21 10:30 ` Russell King - ARM Linux
2010-12-21 10:34 ` Jamie Iles
2010-12-21 11:11 ` Catalin Marinas
2010-12-21 11:22 ` Jamie Iles
2010-12-21 10:36 ` Russell King - ARM Linux [this message]
2010-12-21 11:01 ` [PATCH 1/2] ARM: convert dma-mapping to asm-generic API Jamie Iles
2010-12-21 16:04 ` Jamie Iles
2010-12-22 2:57 ` FUJITA Tomonori
2010-12-21 10:54 ` Arnd Bergmann
2010-12-21 10:59 ` Russell King - ARM Linux
2010-12-21 11:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221103652.GL28157@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox