* [PATCH v2] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines
@ 2010-12-21 10:23 Daniel Morsing
2010-12-22 1:54 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Morsing @ 2010-12-21 10:23 UTC (permalink / raw)
To: linux-arm-kernel
The display reset lines are connected to a TPS65930 which may sleep
when changing GPIO values. Use the appropriate function to silence
a nasty warning from gpiolib.
Signed-off-by: Daniel Morsing <daniel.morsing@gmail.com>
Acked-by: Thomas Weber <weber@corscience.de>
---
Gmail destroyed the previous patch send, so resending with a sane client.
---
arch/arm/mach-omap2/board-devkit8000.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c
index 53ac762..f1f58f5 100644
--- a/arch/arm/mach-omap2/board-devkit8000.c
+++ b/arch/arm/mach-omap2/board-devkit8000.c
@@ -118,27 +118,27 @@ static int devkit8000_panel_enable_lcd(struct omap_dss_device *dssdev)
twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0);
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 1);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 1);
return 0;
}
static void devkit8000_panel_disable_lcd(struct omap_dss_device *dssdev)
{
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 0);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 0);
}
static int devkit8000_panel_enable_dvi(struct omap_dss_device *dssdev)
{
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 1);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 1);
return 0;
}
static void devkit8000_panel_disable_dvi(struct omap_dss_device *dssdev)
{
if (gpio_is_valid(dssdev->reset_gpio))
- gpio_set_value(dssdev->reset_gpio, 0);
+ gpio_set_value_cansleep(dssdev->reset_gpio, 0);
}
static struct regulator_consumer_supply devkit8000_vmmc1_supply =
--
1.7.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines
2010-12-21 10:23 [PATCH v2] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines Daniel Morsing
@ 2010-12-22 1:54 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2010-12-22 1:54 UTC (permalink / raw)
To: linux-arm-kernel
* Daniel Morsing <daniel.morsing@gmail.com> [101221 02:22]:
> The display reset lines are connected to a TPS65930 which may sleep
> when changing GPIO values. Use the appropriate function to silence
> a nasty warning from gpiolib.
>
> Signed-off-by: Daniel Morsing <daniel.morsing@gmail.com>
> Acked-by: Thomas Weber <weber@corscience.de>
Thanks applying.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-22 1:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-21 10:23 [PATCH v2] OMAP2: Devkit8000: Use _cansleep GPIO functions for display reset lines Daniel Morsing
2010-12-22 1:54 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).