public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] S5PC210: universal: update support pmic for c210 universal board
Date: Thu, 23 Dec 2010 09:05:05 +0000	[thread overview]
Message-ID: <20101223090504.GA3636@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1293094587-12502-1-git-send-email-dh09.lee@samsung.com>

On Thu, Dec 23, 2010 at 05:56:27PM +0900, Donghwa Lee wrote:
> @@ -11,10 +11,14 @@
>  #include <linux/serial_core.h>
>  #include <linux/input.h>
>  #include <linux/i2c.h>
> +#include <linux/i2c-gpio.h>
>  #include <linux/gpio_keys.h>
>  #include <linux/gpio.h>

linux/gpio.h included here.

> +#include <linux/fb.h>
>  #include <linux/regulator/machine.h>
>  #include <linux/regulator/fixed.h>
> +#include <linux/regulator/max8952.h>
> +#include <linux/mfd/max8998.h>
>  #include <linux/mmc/host.h>
>  
>  #include <asm/mach/arch.h>
> @@ -25,8 +29,15 @@
>  #include <plat/cpu.h>
>  #include <plat/devs.h>
>  #include <plat/sdhci.h>
> +#include <plat/gpio-cfg.h>
> +#include <plat/gpio-core.h>
> +#include <plat/regs-fb.h>
> +#include <plat/clock.h>
> +#include <plat/iic.h>
>  
> +#include <mach/gpio.h>

So you don't need mach/gpio.h, because:

=== linux/gpio.h ===
#ifndef __LINUX_GPIO_H
#define __LINUX_GPIO_H

/* see Documentation/gpio.txt */

#ifdef CONFIG_GENERIC_GPIO
#include <asm/gpio.h>

#else
...

=== asm/gpio.h ===
#ifndef _ARCH_ARM_GPIO_H
#define _ARCH_ARM_GPIO_H

/* not all ARM platforms necessarily support this API ... */
#include <mach/gpio.h>

#endif /* _ARCH_ARM_GPIO_H */

It gets included via linux/gpio.h.

Don't add asm/gpio.h OR mach/gpio.h includes.  Use linux/gpio.h instead.

  reply	other threads:[~2010-12-23  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-23  8:56 [PATCH] S5PC210: universal: update support pmic for c210 universal board Donghwa Lee
2010-12-23  9:05 ` Russell King - ARM Linux [this message]
2010-12-23  9:06 ` Kyungmin Park
2010-12-23  9:18   ` Donghwa Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101223090504.GA3636@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox