From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 23 Dec 2010 09:05:05 +0000 Subject: [PATCH] S5PC210: universal: update support pmic for c210 universal board In-Reply-To: <1293094587-12502-1-git-send-email-dh09.lee@samsung.com> References: <1293094587-12502-1-git-send-email-dh09.lee@samsung.com> Message-ID: <20101223090504.GA3636@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 23, 2010 at 05:56:27PM +0900, Donghwa Lee wrote: > @@ -11,10 +11,14 @@ > #include > #include > #include > +#include > #include > #include linux/gpio.h included here. > +#include > #include > #include > +#include > +#include > #include > > #include > @@ -25,8 +29,15 @@ > #include > #include > #include > +#include > +#include > +#include > +#include > +#include > > +#include So you don't need mach/gpio.h, because: === linux/gpio.h === #ifndef __LINUX_GPIO_H #define __LINUX_GPIO_H /* see Documentation/gpio.txt */ #ifdef CONFIG_GENERIC_GPIO #include #else ... === asm/gpio.h === #ifndef _ARCH_ARM_GPIO_H #define _ARCH_ARM_GPIO_H /* not all ARM platforms necessarily support this API ... */ #include #endif /* _ARCH_ARM_GPIO_H */ It gets included via linux/gpio.h. Don't add asm/gpio.h OR mach/gpio.h includes. Use linux/gpio.h instead.