* [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
@ 2010-12-24 2:48 Ben Gamari
2010-12-24 17:39 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Ben Gamari @ 2010-12-24 2:48 UTC (permalink / raw)
To: linux-arm-kernel
It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS.
Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems
correct for the architecture to depend upon OMAP_DM_TIMER, otherwise
unsuspecting integrators will be faced with a whole bunch of linker
errors at the end of their kernel build:
arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
/home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
...
---
arch/arm/plat-omap/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index 92c5bb7..784c06c 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -18,6 +18,7 @@ config ARCH_OMAP1
config ARCH_OMAP2PLUS
bool "TI OMAP2/3/4"
select COMMON_CLKDEV
+ select OMAP_DM_TIMER
help
"Systems based on OMAP2, OMAP3 or OMAP4"
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
2010-12-24 2:48 [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
@ 2010-12-24 17:39 ` Tony Lindgren
2010-12-24 17:53 ` Ben Gamari
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2010-12-24 17:39 UTC (permalink / raw)
To: linux-arm-kernel
* Ben Gamari <bgamari.foss@gmail.com> [101223 18:48]:
> It appears that arch/arm/mach-omap2/timer-gp.o is needed by OMAP2PLUS.
> Since timer-gp.o has direct dependencies on omap_dm_timer_*, it seems
> correct for the architecture to depend upon OMAP_DM_TIMER, otherwise
> unsuspecting integrators will be faced with a whole bunch of linker
> errors at the end of their kernel build:
>
> arch/arm/mach-omap2/built-in.o: In function `omap2_gp_timer_set_mode':
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:84: undefined reference to `omap_dm_timer_stop'
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:88: undefined reference to `omap_dm_timer_get_fclk'
> /home/bgamari/trees/linux-2.6/arch/arm/mach-omap2/timer-gp.c:90: undefined reference to `omap_dm_timer_set_load_start'
> ...
One more thing.. Can you please reply with your
Signed-off-by: line so this can be applied?
Thanks
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER
2010-12-24 17:39 ` Tony Lindgren
@ 2010-12-24 17:53 ` Ben Gamari
0 siblings, 0 replies; 3+ messages in thread
From: Ben Gamari @ 2010-12-24 17:53 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 24 Dec 2010 09:39:13 -0800, Tony Lindgren <tony@atomide.com> wrote:
> One more thing.. Can you please reply with your
> Signed-off-by: line so this can be applied?
>
Signed-Off-By: Ben Gamari <bgamari.foss@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-24 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-24 2:48 [PATCH] omap2: Make OMAP2PLUS select OMAP_DM_TIMER Ben Gamari
2010-12-24 17:39 ` Tony Lindgren
2010-12-24 17:53 ` Ben Gamari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).