From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac
Date: Wed, 29 Dec 2010 13:42:21 +0100 [thread overview]
Message-ID: <20101229124220.GD14221@pengutronix.de> (raw)
In-Reply-To: <20101229115808.GF19347@freescale.com>
Hello Shawn,
On Wed, Dec 29, 2010 at 07:58:09PM +0800, Shawn Guo wrote:
> On Wed, Dec 29, 2010 at 11:31:38AM +0100, Uwe Kleine-K?nig wrote:
> > On Wed, Dec 29, 2010 at 06:05:21PM +0800, Shawn Guo wrote:
> > > On Wed, Dec 29, 2010 at 08:53:30AM +0200, Baruch Siach wrote:
> > > if (iap == fec_mac_default)
> > > dev->dev_addr[ETH_ALEN-1] = fec_mac_default[ETH_ALEN-1] + fep->pdev->id;
> > Can this overflow? (I didn't check the code, so my concern might be
> > completely stupid here.)
> No. dev->dev_addr points to netdev_hw_addr->addr, which is a 32 bytes array.
I didn't mean an out-of-bound access, but what is if
fec_mac_default[ETH_ALEN-1] is 0xff and you add 1? Does that result in
0x100 or 0? What if id is <0? For big ids you might even handle a
carry to indixes <ETH_ALEN-2.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-12-29 12:42 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 14:55 [PATCH 00/10] net/fec: add dual fec support for i.MX28 Shawn Guo
2010-12-28 14:55 ` [PATCH 01/10] net/fec: fix MMFR_OP type in fec_enet_mdio_write Shawn Guo
2010-12-28 14:55 ` [PATCH 02/10] net/fec: remove the use of "index" which is legacy Shawn Guo
2010-12-28 14:55 ` [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac Shawn Guo
2010-12-29 5:29 ` Greg Ungerer
2010-12-29 9:51 ` Shawn Guo
2010-12-29 6:53 ` Baruch Siach
2010-12-29 10:05 ` Shawn Guo
2010-12-29 10:31 ` Uwe Kleine-König
2010-12-29 11:58 ` Shawn Guo
2010-12-29 12:42 ` Uwe Kleine-König [this message]
2010-12-30 2:12 ` Shawn Guo
2010-12-30 8:04 ` Uwe Kleine-König
2010-12-30 4:29 ` Shawn Guo
2010-12-30 5:29 ` Baruch Siach
2010-12-30 7:20 ` Shawn Guo
2010-12-29 10:30 ` Shawn Guo
2010-12-29 10:37 ` Uwe Kleine-König
2010-12-29 11:08 ` Shawn Guo
2010-12-29 11:10 ` Uwe Kleine-König
2010-12-29 12:00 ` Shawn Guo
2010-12-28 14:55 ` [PATCH 04/10] net/fec: improve pm for better suspend/resume Shawn Guo
2010-12-28 14:55 ` [PATCH 05/10] net/fec: add dual fec support for mx28 Shawn Guo
2010-12-28 14:55 ` [PATCH 06/10] ARM: mx28: update clocks for dual fec support Shawn Guo
2010-12-29 6:57 ` Baruch Siach
2010-12-29 8:10 ` Uwe Kleine-König
2010-12-29 10:14 ` Shawn Guo
2010-12-29 10:28 ` Uwe Kleine-König
2010-12-28 14:55 ` [PATCH 07/10] ARM: mx28: add the second fec device registration Shawn Guo
2010-12-29 10:50 ` Uwe Kleine-König
2010-12-29 12:05 ` Shawn Guo
2010-12-28 14:55 ` [PATCH 08/10] ARM: mxs: add ocotp read function Shawn Guo
2010-12-29 10:47 ` Uwe Kleine-König
2010-12-29 12:08 ` Shawn Guo
2010-12-29 13:47 ` Uwe Kleine-König
2010-12-29 11:22 ` Uwe Kleine-König
2010-12-30 5:50 ` Shawn Guo
2010-12-30 9:15 ` Uwe Kleine-König
2010-12-31 1:43 ` Shawn Guo
2010-12-31 16:11 ` Uwe Kleine-König
2011-01-01 13:03 ` Shawn Guo
2010-12-30 8:41 ` Shawn Guo
2010-12-30 9:02 ` Uwe Kleine-König
2010-12-31 1:46 ` Shawn Guo
2010-12-28 14:55 ` [PATCH 09/10] ARM: mx28: read fec mac address from ocotp Shawn Guo
2010-12-29 10:53 ` Uwe Kleine-König
2010-12-29 12:13 ` Shawn Guo
2010-12-29 12:45 ` Uwe Kleine-König
2010-12-30 2:19 ` Shawn Guo
2010-12-30 8:33 ` Shawn Guo
2010-12-28 14:55 ` [PATCH 10/10] ARM: mxs: add initial pm support Shawn Guo
2010-12-29 10:57 ` Uwe Kleine-König
2010-12-29 12:15 ` Shawn Guo
2010-12-30 8:50 ` Shawn Guo
2010-12-29 5:26 ` [PATCH 00/10] net/fec: add dual fec support for i.MX28 Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101229124220.GD14221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).