From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM i.MX53: Make MX53 EVK bootable
Date: Fri, 31 Dec 2010 10:12:52 +0800 [thread overview]
Message-ID: <20101231021251.GH28246@freescale.com> (raw)
In-Reply-To: <20101230095142.GV14221@pengutronix.de>
On Thu, Dec 30, 2010 at 10:51:42AM +0100, Uwe Kleine-K?nig wrote:
> Hello Yong,
>
> On Thu, Dec 30, 2010 at 01:28:01PM +0800, yong.shen at freescale.com wrote:
> > From: Yong Shen <yong.shen@linaro.org>
[...]
> > diff --git a/arch/arm/plat-mxc/include/mach/irqs.h b/arch/arm/plat-mxc/include/mach/irqs.h
> > index 86781f7..8f11cfa 100644
> > --- a/arch/arm/plat-mxc/include/mach/irqs.h
> > +++ b/arch/arm/plat-mxc/include/mach/irqs.h
> > @@ -29,8 +29,10 @@
> > #define MXC_GPIO_IRQS (32 * 4)
> > #elif defined CONFIG_ARCH_MX25
> > #define MXC_GPIO_IRQS (32 * 4)
> > -#elif defined CONFIG_ARCH_MX5
> > +#elif defined CONFIG_ARCH_MX51
> > #define MXC_GPIO_IRQS (32 * 4)
> > +#elif defined CONFIG_ARCH_MX53
> > +#define MXC_GPIO_IRQS (32 * 7)
> You didn't read the comment before this block.
>
I did not read the comment either when I was trying to add mxs
support into imx-single-zimage. But the error during the run-time
forced me to go back and read the comment :)
--
Regards,
Shawn
prev parent reply other threads:[~2010-12-31 2:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 5:27 [PATCH v2] ARM i.MX53 MSL patch set yong.shen at freescale.com
2010-12-30 5:28 ` [PATCH v2 1/2] ARM i.MX53: Some bug fix about MX53 MSL code yong.shen at freescale.com
2010-12-30 9:54 ` Uwe Kleine-König
2010-12-30 14:35 ` Richard Zhao
2010-12-31 2:31 ` Yong Shen
2010-12-31 16:20 ` Uwe Kleine-König
2010-12-30 5:28 ` [PATCH v2 2/2] ARM i.MX53: Make MX53 EVK bootable yong.shen at freescale.com
2010-12-30 9:51 ` Uwe Kleine-König
2010-12-31 2:11 ` Yong Shen
2010-12-31 2:12 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231021251.GH28246@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).