* [PATCH] Fix dmaengine_submit() return type
@ 2011-01-01 23:00 Russell King - ARM Linux
2011-01-12 10:30 ` Russell King - ARM Linux
2011-01-14 15:08 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2011-01-01 23:00 UTC (permalink / raw)
To: linux-arm-kernel
desc->tx_submit's return type is dma_cookie_t, not int. Therefore,
dmaengine_submit() should match this return type as it's just
wrapping this detail.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
include/linux/dmaengine.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index 9d8688b..830935b 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -532,7 +532,7 @@ static inline int dmaengine_resume(struct dma_chan *chan)
return dmaengine_device_control(chan, DMA_RESUME, 0);
}
-static inline int dmaengine_submit(struct dma_async_tx_descriptor *desc)
+static inline dma_cookie_t dmaengine_submit(struct dma_async_tx_descriptor *desc)
{
return desc->tx_submit(desc);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] Fix dmaengine_submit() return type
2011-01-01 23:00 [PATCH] Fix dmaengine_submit() return type Russell King - ARM Linux
@ 2011-01-12 10:30 ` Russell King - ARM Linux
2011-01-14 15:08 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2011-01-12 10:30 UTC (permalink / raw)
To: linux-arm-kernel
Ping?
On Sat, Jan 01, 2011 at 11:00:23PM +0000, Russell King - ARM Linux wrote:
> desc->tx_submit's return type is dma_cookie_t, not int. Therefore,
> dmaengine_submit() should match this return type as it's just
> wrapping this detail.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> include/linux/dmaengine.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 9d8688b..830935b 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -532,7 +532,7 @@ static inline int dmaengine_resume(struct dma_chan *chan)
> return dmaengine_device_control(chan, DMA_RESUME, 0);
> }
>
> -static inline int dmaengine_submit(struct dma_async_tx_descriptor *desc)
> +static inline dma_cookie_t dmaengine_submit(struct dma_async_tx_descriptor *desc)
> {
> return desc->tx_submit(desc);
> }
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] Fix dmaengine_submit() return type
2011-01-01 23:00 [PATCH] Fix dmaengine_submit() return type Russell King - ARM Linux
2011-01-12 10:30 ` Russell King - ARM Linux
@ 2011-01-14 15:08 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2011-01-14 15:08 UTC (permalink / raw)
To: linux-arm-kernel
2011/1/2 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> desc->tx_submit's return type is dma_cookie_t, not int. ?Therefore,
> dmaengine_submit() should match this return type as it's just
> wrapping this detail.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
FWIW
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-14 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-01 23:00 [PATCH] Fix dmaengine_submit() return type Russell King - ARM Linux
2011-01-12 10:30 ` Russell King - ARM Linux
2011-01-14 15:08 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).