* [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless
@ 2010-12-24 6:26 Seungwhan Youn
2010-12-24 6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Seungwhan Youn @ 2010-12-24 6:26 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
These patches modify configuration to make audio support configurations on
platform(or arch) from sound/soc/samsung. This prevents that audio config
consider which board(or arch) can(or should) support ASoC audio driver, and
also prevents audio config dependancy on future Samsung SoCs.
These patches are modify below features:-
o Add audio configurations on plat(or arch).
o Modify audio configuration depends on plat(or arch) selection on ASoC.
This patch-set is based on two different branches that :-
o ARM patches are based on Kukjin Kim's git branch 'for-next'
(commit id - 30fb9a94ec22435add3d2ea2d1b01c1a5ad6164c)
o ASoC patches are based on Mark Brown's git branch 'for-next'
(commit id - 722bc28384accb67c0bfbbe1914fd82d4d0c996a)
This patch-set contains followings :-
o To Kukjin Kim, Ben Dooks and Russell King,
- [PATCH 1/4] ARM: Kconfig: Add audio support dependency
- [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
o To Jassi Brar, Mark Brown and Liam Girdwood,
- [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration
- [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations
Marry X-mas,
Claude(Seungwhan Youn)
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] ARM: Kconfig: Add audio support dependency
2010-12-24 6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
@ 2010-12-24 6:36 ` Seungwhan Youn
2011-01-02 14:05 ` Mark Brown
2011-01-03 2:28 ` Kukjin Kim
2010-12-24 6:42 ` [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration Seungwhan Youn
` (3 subsequent siblings)
4 siblings, 2 replies; 14+ messages in thread
From: Seungwhan Youn @ 2010-12-24 6:36 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds Samsung ASoC audio support dependency for Samsung SoCs.
Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
---
arch/arm/Kconfig | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index d56d21c..ef32a61 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -647,6 +647,7 @@ config ARCH_S3C2410
select HAVE_CLK
select ARCH_USES_GETTIMEOFFSET
select HAVE_S3C2410_I2C if I2C
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S3C2410X CPU based systems, such as the Simtec Electronics
BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
@@ -678,6 +679,7 @@ config ARCH_S3C64XX
select SAMSUNG_GPIOLIB_4BIT
select HAVE_S3C2410_I2C if I2C
select HAVE_S3C2410_WATCHDOG if WATCHDOG
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S3C64XX series based systems
@@ -690,6 +692,7 @@ config ARCH_S5P64X0
select ARCH_USES_GETTIMEOFFSET
select HAVE_S3C2410_I2C if I2C
select HAVE_S3C_RTC if RTC_CLASS
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S5P64X0 CPU based systems, such as the Samsung SMDK6440,
SMDK6450.
@@ -701,6 +704,7 @@ config ARCH_S5P6442
select HAVE_CLK
select ARCH_USES_GETTIMEOFFSET
select HAVE_S3C2410_WATCHDOG if WATCHDOG
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S5P6442 CPU based systems
@@ -714,6 +718,7 @@ config ARCH_S5PC100
select HAVE_S3C2410_I2C if I2C
select HAVE_S3C_RTC if RTC_CLASS
select HAVE_S3C2410_WATCHDOG if WATCHDOG
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S5PC100 series based systems
@@ -729,6 +734,7 @@ config ARCH_S5PV210
select HAVE_S3C2410_I2C if I2C
select HAVE_S3C_RTC if RTC_CLASS
select HAVE_S3C2410_WATCHDOG if WATCHDOG
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S5PV210/S5PC110 series based systems
@@ -742,6 +748,7 @@ config ARCH_S5PV310
select HAVE_S3C_RTC if RTC_CLASS
select HAVE_S3C2410_I2C if I2C
select HAVE_S3C2410_WATCHDOG if WATCHDOG
+ select ASOC_SAMSUNG if SND_SOC
help
Samsung S5PV310 series based systems
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
2010-12-24 6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
2010-12-24 6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
@ 2010-12-24 6:42 ` Seungwhan Youn
2010-12-24 11:49 ` Mark Brown
2011-01-02 14:01 ` Mark Brown
2010-12-24 6:46 ` [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration Seungwhan Youn
` (2 subsequent siblings)
4 siblings, 2 replies; 14+ messages in thread
From: Seungwhan Youn @ 2010-12-24 6:42 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds SMDK audio select configurations based on platform dependacny.
This helps more easyly and clearly to make sure about configuration on audio
drivers support on platform side.
Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
---
arch/arm/mach-s3c2443/Kconfig | 1 +
arch/arm/mach-s3c64xx/Kconfig | 3 +++
arch/arm/mach-s5p6442/Kconfig | 2 ++
arch/arm/mach-s5p64x0/Kconfig | 4 ++++
arch/arm/mach-s5pc100/Kconfig | 4 ++++
arch/arm/mach-s5pv210/Kconfig | 8 ++++++++
arch/arm/mach-s5pv310/Kconfig | 8 ++++++++
7 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s3c2443/Kconfig b/arch/arm/mach-s3c2443/Kconfig
index 31babec..8a3052f 100644
--- a/arch/arm/mach-s3c2443/Kconfig
+++ b/arch/arm/mach-s3c2443/Kconfig
@@ -26,6 +26,7 @@ config MACH_SMDK2443
select CPU_S3C2443
select MACH_SMDK
select S3C_DEV_HSMMC
+ select SMDK_HAS_WM9710_AC97 if ASOC_SAMSUNG
help
Say Y here if you are using an SMDK2443
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 579d2f0..02caae9 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -149,6 +149,9 @@ config MACH_SMDK6410
select S3C64XX_SETUP_IDE
select S3C64XX_SETUP_FB_24BPP
select S3C64XX_SETUP_KEYPAD
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
+ select SMDK_HAS_WM9713_AC97 if ASOC_SAMSUNG
help
Machine support for the Samsung SMDK6410
diff --git a/arch/arm/mach-s5p6442/Kconfig b/arch/arm/mach-s5p6442/Kconfig
index 33569e4..24c8131 100644
--- a/arch/arm/mach-s5p6442/Kconfig
+++ b/arch/arm/mach-s5p6442/Kconfig
@@ -19,6 +19,8 @@ config MACH_SMDK6442
bool "SMDK6442"
select CPU_S5P6442
select S3C_DEV_WDT
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
help
Machine support for Samsung SMDK6442
diff --git a/arch/arm/mach-s5p64x0/Kconfig b/arch/arm/mach-s5p64x0/Kconfig
index 164d278..005f1e5 100644
--- a/arch/arm/mach-s5p64x0/Kconfig
+++ b/arch/arm/mach-s5p64x0/Kconfig
@@ -36,6 +36,8 @@ config MACH_SMDK6440
select SAMSUNG_DEV_ADC
select SAMSUNG_DEV_TS
select S5P64X0_SETUP_I2C1
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
help
Machine support for the Samsung SMDK6440
@@ -49,6 +51,8 @@ config MACH_SMDK6450
select SAMSUNG_DEV_ADC
select SAMSUNG_DEV_TS
select S5P64X0_SETUP_I2C1
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
help
Machine support for the Samsung SMDK6450
diff --git a/arch/arm/mach-s5pc100/Kconfig b/arch/arm/mach-s5pc100/Kconfig
index b8fbf2f..fb9befd 100644
--- a/arch/arm/mach-s5pc100/Kconfig
+++ b/arch/arm/mach-s5pc100/Kconfig
@@ -67,6 +67,10 @@ config MACH_SMDKC100
select S5P_DEV_FIMC0
select S5P_DEV_FIMC1
select S5P_DEV_FIMC2
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
+ select SMDK_HAS_WM9713_AC97 if ASOC_SAMSUNG
+ select SMDK_HAS_SPDIF if ASOC_SAMSUNG
help
Machine support for the Samsung SMDKC100
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 53aabef..44a4e5f 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -107,6 +107,10 @@ config MACH_SMDKC110
select S5PV210_SETUP_I2C1
select S5PV210_SETUP_I2C2
select S5PV210_SETUP_IDE
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
+ select SMDK_HAS_WM9713_AC97 if ASOC_SAMSUNG
+ select SMDK_HAS_SPDIF if ASOC_SAMSUNG
help
Machine support for Samsung SMDKC110
S5PC110(MCP) is one of package option of S5PV210
@@ -137,6 +141,10 @@ config MACH_SMDKV210
select S5PV210_SETUP_IDE
select S5PV210_SETUP_KEYPAD
select S5PV210_SETUP_SDHCI
+ select SMDK_HAS_WM8580_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8580_PCM if ASOC_SAMSUNG
+ select SMDK_HAS_WM9713_AC97 if ASOC_SAMSUNG
+ select SMDK_HAS_SPDIF if ASOC_SAMSUNG
help
Machine support for Samsung SMDKV210
diff --git a/arch/arm/mach-s5pv310/Kconfig b/arch/arm/mach-s5pv310/Kconfig
index b7aa3cd..ed0926a 100644
--- a/arch/arm/mach-s5pv310/Kconfig
+++ b/arch/arm/mach-s5pv310/Kconfig
@@ -83,6 +83,10 @@ config MACH_SMDKC210
select S5PV310_DEV_PD
select S5PV310_SETUP_I2C1
select S5PV310_SETUP_SDHCI
+ select SMDK_HAS_WM8994_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8994_PCM if ASOC_SAMSUNG
+ select SMDK_HAS_WM9713_AC97 if ASOC_SAMSUNG
+ select SMDK_HAS_SPDIF if ASOC_SAMSUNG
help
Machine support for Samsung SMDKC210
S5PC210(MCP) is one of package option of S5PV310
@@ -118,6 +122,10 @@ config MACH_SMDKV310
select S5PV310_DEV_PD
select S5PV310_SETUP_I2C1
select S5PV310_SETUP_SDHCI
+ select SMDK_HAS_WM8994_I2S if ASOC_SAMSUNG
+ select SMDK_HAS_WM8994_PCM if ASOC_SAMSUNG
+ select SMDK_HAS_WM9713_AC97 if ASOC_SAMSUNG
+ select SMDK_HAS_SPDIF if ASOC_SAMSUNG
help
Machine support for Samsung SMDKV310
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration
2010-12-24 6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
2010-12-24 6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
2010-12-24 6:42 ` [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration Seungwhan Youn
@ 2010-12-24 6:46 ` Seungwhan Youn
2010-12-24 6:57 ` [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations Seungwhan Youn
2010-12-24 7:56 ` [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Jassi Brar
4 siblings, 0 replies; 14+ messages in thread
From: Seungwhan Youn @ 2010-12-24 6:46 UTC (permalink / raw)
To: linux-arm-kernel
This patch modify to support ASoC Samsung which is selected HAVE_ASOC_SAMSUNG
from platform configuration automatically. After this, ASoC has not consider
which arch(or plat) adds to support audio driver.
Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
---
sound/soc/samsung/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index 11ff4ad..90fe869 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -1,6 +1,5 @@
config ASOC_SAMSUNG
tristate "ASoC support for Samsung"
- depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5PC100 || ARCH_S5PV210 || ARCH_S5P64X0 || ARCH_S5P6442 || ARCH_S5PV310
select S3C64XX_DMA if ARCH_S3C64XX
select S3C2410_DMA if ARCH_S3C2410
help
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations
2010-12-24 6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
` (2 preceding siblings ...)
2010-12-24 6:46 ` [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration Seungwhan Youn
@ 2010-12-24 6:57 ` Seungwhan Youn
2010-12-24 7:56 ` [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Jassi Brar
4 siblings, 0 replies; 14+ messages in thread
From: Seungwhan Youn @ 2010-12-24 6:57 UTC (permalink / raw)
To: linux-arm-kernel
This patch apply SMDK audio configurations which depends on platform
configurations. This makes more seperate select audio configurations,
because after apply this audio configuration does not consider about
which SMDK board or ARCH is selected.
Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
---
sound/soc/samsung/Kconfig | 31 ++++++++++++++++++++++++++-----
1 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index 90fe869..163dceb 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -33,6 +33,27 @@ config SND_SAMSUNG_SPDIF
config SND_SAMSUNG_I2S
tristate
+config SMDK_HAS_WM8580_I2S
+ bool
+
+config SMDK_HAS_WM8994_I2S
+ bool
+
+config SMDK_HAS_WM8580_PCM
+ bool
+
+config SMDK_HAS_WM8994_PCM
+ bool
+
+config SMDK_HAS_WM9710_AC97
+ bool
+
+config SMDK_HAS_WM9713_AC97
+ bool
+
+config SMDK_HAS_SPDIF
+ bool
+
config ASOC_SAMSUNG_NEO1973_WM8753
tristate "SoC I2S Audio support for NEO1973 - WM8753"
depends on ASOC_SAMSUNG && MACH_NEO1973_GTA01
@@ -61,7 +82,7 @@ config ASOC_SAMSUNG_JIVE_WM8750
config ASOC_SAMSUNG_SMDK_WM8580
tristate "SoC I2S Audio support for WM8580 on SMDK"
- depends on ASOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDK6440 || MACH_SMDK6450 || MACH_SMDK6442 || MACH_SMDKV210 || MACH_SMDKC110)
+ depends on SMDK_HAS_WM8580_I2S
select SND_SOC_WM8580
select SND_SAMSUNG_I2S
help
@@ -69,7 +90,7 @@ config ASOC_SAMSUNG_SMDK_WM8580
config ASOC_SAMSUNG_SMDK_WM8994
tristate "SoC I2S Audio support for WM8994 on SMDK"
- depends on ASOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210)
+ depends on SMDK_HAS_WM8994_I2S
select SND_SOC_WM8994
select SND_SAMSUNG_I2S
help
@@ -77,7 +98,7 @@ config ASOC_SAMSUNG_SMDK_WM8994
config ASOC_SAMSUNG_SMDK2443_WM9710
tristate "SoC AC97 Audio support for SMDK2443 - WM9710"
- depends on ASOC_SAMSUNG && MACH_SMDK2443
+ depends on SMDK_HAS_WM9710_AC97
select S3C2410_DMA
select AC97_BUS
select SND_SOC_AC97_CODEC
@@ -141,7 +162,7 @@ config ASOC_SAMSUNG_RX1950_UDA1380
config ASOC_SAMSUNG_SMDK_WM9713
tristate "SoC AC97 Audio support for SMDK with WM9713"
- depends on ASOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210)
+ depends on SMDK_HAS_WM9713_AC97
select SND_SOC_WM9713
select SND_SAMSUNG_AC97
help
@@ -164,7 +185,7 @@ config ASOC_GONI_AQUILA_WM8994
config ASOC_SAMSUNG_SMDK_SPDIF
tristate "SoC S/PDIF Audio support for SMDK"
- depends on ASOC_SAMSUNG && (MACH_SMDKC100 || MACH_SMDKC110 || MACH_SMDKV210)
+ depends on SMDK_HAS_SPDIF
select SND_SAMSUNG_SPDIF
help
Say Y if you want to add support for SoC S/PDIF audio on the SMDK.
--
1.6.2.5
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless
2010-12-24 6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
` (3 preceding siblings ...)
2010-12-24 6:57 ` [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations Seungwhan Youn
@ 2010-12-24 7:56 ` Jassi Brar
2010-12-24 11:43 ` Liam Girdwood
4 siblings, 1 reply; 14+ messages in thread
From: Jassi Brar @ 2010-12-24 7:56 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 24, 2010 at 3:26 PM, Seungwhan Youn <sw.youn@samsung.com> wrote:
> Hi,
>
> These patches modify configuration to make audio support configurations on
> platform(or arch) from sound/soc/samsung. This prevents that audio config
> consider which board(or arch) can(or should) support ASoC audio driver, and
> also prevents audio config dependancy on future Samsung SoCs.
>
>
> These patches are modify below features:-
> ?o Add audio configurations on plat(or arch).
> ?o Modify audio configuration depends on plat(or arch) selection on ASoC.
>
> This patch-set is based on two different branches that :-
> ?o ARM patches are based on Kukjin Kim's git branch 'for-next'
> ? (commit id - 30fb9a94ec22435add3d2ea2d1b01c1a5ad6164c)
> ?o ASoC patches are based on Mark Brown's git branch 'for-next'
> ? (commit id - 722bc28384accb67c0bfbbe1914fd82d4d0c996a)
>
> This patch-set contains followings :-
> ?o To Kukjin Kim, Ben Dooks and Russell King,
> ?- [PATCH 1/4] ARM: Kconfig: Add audio support dependency
> ?- [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
> ?o To Jassi Brar, Mark Brown and Liam Girdwood,
> ?- [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration
> ?- [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations
All,
Acked-by : Jassi Brar <jassi.brar@samsung.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless
2010-12-24 7:56 ` [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Jassi Brar
@ 2010-12-24 11:43 ` Liam Girdwood
0 siblings, 0 replies; 14+ messages in thread
From: Liam Girdwood @ 2010-12-24 11:43 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2010-12-24 at 16:56 +0900, Jassi Brar wrote:
> On Fri, Dec 24, 2010 at 3:26 PM, Seungwhan Youn <sw.youn@samsung.com> wrote:
> > Hi,
> >
> > These patches modify configuration to make audio support configurations on
> > platform(or arch) from sound/soc/samsung. This prevents that audio config
> > consider which board(or arch) can(or should) support ASoC audio driver, and
> > also prevents audio config dependancy on future Samsung SoCs.
> >
> >
> > These patches are modify below features:-
> > o Add audio configurations on plat(or arch).
> > o Modify audio configuration depends on plat(or arch) selection on ASoC.
> >
> > This patch-set is based on two different branches that :-
> > o ARM patches are based on Kukjin Kim's git branch 'for-next'
> > (commit id - 30fb9a94ec22435add3d2ea2d1b01c1a5ad6164c)
> > o ASoC patches are based on Mark Brown's git branch 'for-next'
> > (commit id - 722bc28384accb67c0bfbbe1914fd82d4d0c996a)
> >
> > This patch-set contains followings :-
> > o To Kukjin Kim, Ben Dooks and Russell King,
> > - [PATCH 1/4] ARM: Kconfig: Add audio support dependency
> > - [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
> > o To Jassi Brar, Mark Brown and Liam Girdwood,
> > - [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration
> > - [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations
>
> All,
> Acked-by : Jassi Brar <jassi.brar@samsung.com>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
2010-12-24 6:42 ` [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration Seungwhan Youn
@ 2010-12-24 11:49 ` Mark Brown
2010-12-27 1:31 ` [alsa-devel] " Seungwhan Youn
2011-01-02 14:01 ` Mark Brown
1 sibling, 1 reply; 14+ messages in thread
From: Mark Brown @ 2010-12-24 11:49 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 24, 2010 at 03:42:18PM +0900, Seungwhan Youn wrote:
> select S3C_DEV_HSMMC
> + select SMDK_HAS_WM9710_AC97 if ASOC_SAMSUNG
> help
There's no need for the ifs here - since the actual machine driver is a
user visible control and the SMDK_HAS_ are just dependencies for that
it's more normal to just select the symbol.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [alsa-devel] [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
2010-12-24 11:49 ` Mark Brown
@ 2010-12-27 1:31 ` Seungwhan Youn
0 siblings, 0 replies; 14+ messages in thread
From: Seungwhan Youn @ 2010-12-27 1:31 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 24, 2010 at 8:49 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Dec 24, 2010 at 03:42:18PM +0900, Seungwhan Youn wrote:
>
>> ? ? ? select S3C_DEV_HSMMC
>> + ? ? select SMDK_HAS_WM9710_AC97 if ASOC_SAMSUNG
>> ? ? ? help
>
> There's no need for the ifs here - since the actual machine driver is a
> user visible control and the SMDK_HAS_ are just dependencies for that
> it's more normal to just select the symbol.
The 'if' seems to be necessary, otherwise we get 'unmet direct
dependency' warning message and the menuconfig shows messed up.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
2010-12-24 6:42 ` [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration Seungwhan Youn
2010-12-24 11:49 ` Mark Brown
@ 2011-01-02 14:01 ` Mark Brown
2011-01-03 1:30 ` [alsa-devel] " Seungwhan Youn
1 sibling, 1 reply; 14+ messages in thread
From: Mark Brown @ 2011-01-02 14:01 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 24, 2010 at 03:42:18PM +0900, Seungwhan Youn wrote:
> This patch adds SMDK audio select configurations based on platform dependacny.
> This helps more easyly and clearly to make sure about configuration on audio
> drivers support on platform side.
>
> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
This doesn't apply against current ASoC; I suspect it needs to be merged
via the ARM tree.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] ARM: Kconfig: Add audio support dependency
2010-12-24 6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
@ 2011-01-02 14:05 ` Mark Brown
2011-01-03 1:37 ` [alsa-devel] " Seungwhan Youn
2011-01-03 2:28 ` Kukjin Kim
1 sibling, 1 reply; 14+ messages in thread
From: Mark Brown @ 2011-01-02 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 24, 2010 at 03:36:09PM +0900, Seungwhan Youn wrote:
> This patch adds Samsung ASoC audio support dependency for Samsung SoCs.
> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
> + select ASOC_SAMSUNG if SND_SOC
Hrm, if we're going to do this we probably ought to be doing it for all
architectures. It's a good idea, we don't tend to have multiple
possible architectures supported for a given architecture. Since the
second patch didn't apply I'll leave this one too, and patches 3 and 4,
though they all look good.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [alsa-devel] [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
2011-01-02 14:01 ` Mark Brown
@ 2011-01-03 1:30 ` Seungwhan Youn
0 siblings, 0 replies; 14+ messages in thread
From: Seungwhan Youn @ 2011-01-03 1:30 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jan 2, 2011 at 11:01 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Dec 24, 2010 at 03:42:18PM +0900, Seungwhan Youn wrote:
>> This patch adds SMDK audio select configurations based on platform dependacny.
>> This helps more easyly and clearly to make sure about configuration on audio
>> drivers support on platform side.
>>
>> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
>
> This doesn't apply against current ASoC; I suspect it needs to be merged
> via the ARM tree.
Yes, patch 1/4 and 2/4 was based on Mr. Kukjin Kim's for-next branch.
So, I hope that Mr. Kukjin Kim sync with you, after he apply these 1,2
patches.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [alsa-devel] [PATCH 1/4] ARM: Kconfig: Add audio support dependency
2011-01-02 14:05 ` Mark Brown
@ 2011-01-03 1:37 ` Seungwhan Youn
0 siblings, 0 replies; 14+ messages in thread
From: Seungwhan Youn @ 2011-01-03 1:37 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jan 2, 2011 at 11:05 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Dec 24, 2010 at 03:36:09PM +0900, Seungwhan Youn wrote:
>
>> This patch adds Samsung ASoC audio support dependency for Samsung SoCs.
>
>> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
>
>> + ? ? select ASOC_SAMSUNG if SND_SOC
>
> Hrm, if we're going to do this we probably ought to be doing it for all
> architectures. ?It's a good idea, we don't tend to have multiple
> possible architectures supported for a given architecture. ?Since the
> second patch didn't apply I'll leave this one too, and patches 3 and 4,
> though they all look good.
Yes, I think so, but I didn't think that far when I made these
patches. If you don't mind, can I re-make this patch-set for all
architectures with your 'Requested-by'?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/4] ARM: Kconfig: Add audio support dependency
2010-12-24 6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
2011-01-02 14:05 ` Mark Brown
@ 2011-01-03 2:28 ` Kukjin Kim
1 sibling, 0 replies; 14+ messages in thread
From: Kukjin Kim @ 2011-01-03 2:28 UTC (permalink / raw)
To: linux-arm-kernel
Seungwhan Youn wrote:
>
> This patch adds Samsung ASoC audio support dependency for Samsung SoCs.
>
> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
> ---
> arch/arm/Kconfig | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index d56d21c..ef32a61 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -647,6 +647,7 @@ config ARCH_S3C2410
> select HAVE_CLK
> select ARCH_USES_GETTIMEOFFSET
> select HAVE_S3C2410_I2C if I2C
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S3C2410X CPU based systems, such as the Simtec Electronics
> BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940
> or
> @@ -678,6 +679,7 @@ config ARCH_S3C64XX
> select SAMSUNG_GPIOLIB_4BIT
> select HAVE_S3C2410_I2C if I2C
> select HAVE_S3C2410_WATCHDOG if WATCHDOG
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S3C64XX series based systems
>
> @@ -690,6 +692,7 @@ config ARCH_S5P64X0
> select ARCH_USES_GETTIMEOFFSET
> select HAVE_S3C2410_I2C if I2C
> select HAVE_S3C_RTC if RTC_CLASS
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S5P64X0 CPU based systems, such as the Samsung SMDK6440,
> SMDK6450.
> @@ -701,6 +704,7 @@ config ARCH_S5P6442
> select HAVE_CLK
> select ARCH_USES_GETTIMEOFFSET
> select HAVE_S3C2410_WATCHDOG if WATCHDOG
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S5P6442 CPU based systems
>
> @@ -714,6 +718,7 @@ config ARCH_S5PC100
> select HAVE_S3C2410_I2C if I2C
> select HAVE_S3C_RTC if RTC_CLASS
> select HAVE_S3C2410_WATCHDOG if WATCHDOG
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S5PC100 series based systems
>
> @@ -729,6 +734,7 @@ config ARCH_S5PV210
> select HAVE_S3C2410_I2C if I2C
> select HAVE_S3C_RTC if RTC_CLASS
> select HAVE_S3C2410_WATCHDOG if WATCHDOG
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S5PV210/S5PC110 series based systems
>
> @@ -742,6 +748,7 @@ config ARCH_S5PV310
> select HAVE_S3C_RTC if RTC_CLASS
> select HAVE_S3C2410_I2C if I2C
> select HAVE_S3C2410_WATCHDOG if WATCHDOG
> + select ASOC_SAMSUNG if SND_SOC
> help
> Samsung S5PV310 series based systems
>
> --
Hi everyone,
Wow it's 2011, I hope you're happy :-)
Hmm...sorry for late.
Looks ok to me..but I know, you changed the name 'ASOC_SAMSUNG' to
'SND_SOC_SAMSUNG'.
So I'm waiting for updated patch now.
Mr. Youn, could you please update your patch against on sound-2.6 tree?
Or...Mark, what's your plan about this, please let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-01-03 2:28 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-24 6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
2010-12-24 6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
2011-01-02 14:05 ` Mark Brown
2011-01-03 1:37 ` [alsa-devel] " Seungwhan Youn
2011-01-03 2:28 ` Kukjin Kim
2010-12-24 6:42 ` [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration Seungwhan Youn
2010-12-24 11:49 ` Mark Brown
2010-12-27 1:31 ` [alsa-devel] " Seungwhan Youn
2011-01-02 14:01 ` Mark Brown
2011-01-03 1:30 ` [alsa-devel] " Seungwhan Youn
2010-12-24 6:46 ` [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration Seungwhan Youn
2010-12-24 6:57 ` [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations Seungwhan Youn
2010-12-24 7:56 ` [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Jassi Brar
2010-12-24 11:43 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).