From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/04] ARM i.MX25 Add SIM driver
Date: Mon, 3 Jan 2011 13:48:04 +0000 [thread overview]
Message-ID: <20110103134804.GL26785@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110103130551.GA24408@pengutronix.de>
On Mon, Jan 03, 2011 at 02:05:51PM +0100, Sascha Hauer wrote:
> The following comments are mostly coding style related, running Lindent
> and checkpatch.pl on this patch seems to be a good start for improving
> this driver.
Beware of Lindent - it can scrunch lines against the right hand side.
Always build the driver before you Lindent it, take a copy of the object
file, then Lindent it, and then re-build it and confirm that the resulting
code and data is indentical. A Lindent shouldn't ever change the produced
code, but unfortunately it has been known to do so.
Keep the Lindenting as a single commit - never combine it with other stuff.
Always go through the driver after running Lindent and fix up scrunches
on the right hand side by hand (maybe it needs the function splitting
into a few helper functions?) Commit these (and any other fixups) as a
follow-on commit.
next prev parent reply other threads:[~2011-01-03 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 9:07 [PATCH 02/04] ARM i.MX25 Add SIM driver FQ | Iban Cerro
2011-01-03 10:14 ` Russell King - ARM Linux
2011-01-03 13:05 ` Sascha Hauer
2011-01-03 13:48 ` Russell King - ARM Linux [this message]
2011-01-03 15:03 ` Jaume Ribot
2011-01-03 15:27 ` Russell King - ARM Linux
2011-01-03 15:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103134804.GL26785@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox