From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm/pxa: buildfix for pam27x without fb
Date: Mon, 3 Jan 2011 23:07:59 +0100 [thread overview]
Message-ID: <201101032308.00036.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTi=mtu3VibUR5SC+GmsmJCwo-nN9=eoTmzUE9jS8@mail.gmail.com>
On Monday 03 January 2011 16:57:27 Eric Miao wrote:
> On Thu, Dec 30, 2010 at 4:33 AM, Sebastian Andrzej Siewior
>
> <bigeasy@linutronix.de> wrote:
> > |arch/arm/mach-pxa/palmld.c: In function ?palmld_init?:
> > |arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode?
> > |undeclared (first use in this function) arch/arm/mach-pxa/palmld.c:330:
> > |error: (Each undeclared identifier is reported only once
> > |arch/arm/mach-pxa/palmld.c:330: error: for each function it appears
> > |in.)
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Marek,
>
> I need your ack please.
I don't like it being done with preprocessor macro. Maybe we should rather pull
palm_320x320_new_lcd_mode and others outside the #if defined() ?
>
> > ---
> > arch/arm/mach-pxa/include/mach/palm27x.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h
> > b/arch/arm/mach-pxa/include/mach/palm27x.h index 0a5e5ea..7b7927c 100644
> > --- a/arch/arm/mach-pxa/include/mach/palm27x.h
> > +++ b/arch/arm/mach-pxa/include/mach/palm27x.h
> > @@ -34,7 +34,7 @@ extern struct pxafb_mode_info
> > palm_320x320_new_lcd_mode; extern void __init palm27x_lcd_init(int
> > power,
> > struct pxafb_mode_info *mode);
> > #else
> > -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info
> > *mode) {} +#define palm27x_lcd_init(power, mode) do { } while (0)
> > #endif
> >
> > #if defined(CONFIG_USB_GADGET_PXA27X) || \
> > --
> > 1.7.3.2
next prev parent reply other threads:[~2011-01-03 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 20:33 [PATCH 1/2] arm/pxa: fix build of it8152 Sebastian Andrzej Siewior
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
2011-01-03 15:57 ` Eric Miao
2011-01-03 22:07 ` Marek Vasut [this message]
2011-01-04 4:00 ` Eric Miao
2010-12-30 7:56 ` [PATCH 1/2] arm/pxa: fix build of it8152 Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101032308.00036.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).