From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Mon, 3 Jan 2011 23:07:59 +0100 Subject: [PATCH 2/2] arm/pxa: buildfix for pam27x without fb In-Reply-To: References: <1293654828-24661-1-git-send-email-bigeasy@linutronix.de> <1293654828-24661-2-git-send-email-bigeasy@linutronix.de> Message-ID: <201101032308.00036.marek.vasut@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 03 January 2011 16:57:27 Eric Miao wrote: > On Thu, Dec 30, 2010 at 4:33 AM, Sebastian Andrzej Siewior > > wrote: > > |arch/arm/mach-pxa/palmld.c: In function ?palmld_init?: > > |arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode? > > |undeclared (first use in this function) arch/arm/mach-pxa/palmld.c:330: > > |error: (Each undeclared identifier is reported only once > > |arch/arm/mach-pxa/palmld.c:330: error: for each function it appears > > |in.) > > > > Signed-off-by: Sebastian Andrzej Siewior > > Marek, > > I need your ack please. I don't like it being done with preprocessor macro. Maybe we should rather pull palm_320x320_new_lcd_mode and others outside the #if defined() ? > > > --- > > arch/arm/mach-pxa/include/mach/palm27x.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h > > b/arch/arm/mach-pxa/include/mach/palm27x.h index 0a5e5ea..7b7927c 100644 > > --- a/arch/arm/mach-pxa/include/mach/palm27x.h > > +++ b/arch/arm/mach-pxa/include/mach/palm27x.h > > @@ -34,7 +34,7 @@ extern struct pxafb_mode_info > > palm_320x320_new_lcd_mode; extern void __init palm27x_lcd_init(int > > power, > > struct pxafb_mode_info *mode); > > #else > > -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info > > *mode) {} +#define palm27x_lcd_init(power, mode) do { } while (0) > > #endif > > > > #if defined(CONFIG_USB_GADGET_PXA27X) || \ > > -- > > 1.7.3.2