From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] variable PHYS_OFFSET support
Date: Tue, 4 Jan 2011 10:41:12 +0000 [thread overview]
Message-ID: <20110104104112.GB16671@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1294129208-15201-1-git-send-email-nico@fluxnic.net>
On Tue, Jan 04, 2011 at 03:20:04AM -0500, Nicolas Pitre wrote:
> So here it is, in a form which I think should be ready for merging.
>
> ARM mode is well tested.
> Thumb2 mode is only compile tested at the moment.
I don't believe this is ready for merging - there's still work to be
done with the early assembly code using PHYS_OFFSET. That currently
doesn't _appear_ to be a problem because it still uses the old platform
specific setting of PHYS_OFFSET - and that needs careful thought as:
#if (PHYS_OFFSET & 0x001fffff)
#error "PHYS_OFFSET must be at an even 2MiB boundary!"
#endif
has been eroded from 16MB downwards to 2MB over time because of
platform setups - eg, MSM for example.
As we're having to store the p:v offset (it's cheaper to store it than
your way of making PHYS_OFFSET depend on the translation and PAGE_OFFSET)
then we might as well also store what we think is the physical offset
and use that for PHYS_OFFSET too once the assembly code issue has been
sorted.
So, what I suggest is a different patch ordering:
1. Fix the assembly code not to rely upon a fixed PHYS_OFFSET (is this
even possible with the 2MB requirement?)
2. Fix the initializers in platform code (ignoring MSM).
3. Rename PHYS_OFFSET to be PLAT_PHYS_OFFSET in platform memory.h files,
defining PHYS_OFFSET in asm/memory.h to be PLAT_PHYS_OFFSET. (We
could make PHYS_OFFSET at this point be a variable, which'd stop any
new initializers using PHYS_OFFSET - which I think would be beneficial
anyway.)
4. Introduce P2V patching _with_ the module support. With this patch
create __pv_phys_offset, and if P2V patching is enabled, redefine
PHYS_OFFSET to be this variable. Note that __pv_phys_offset would
need to be exported to modules.
So, I don't think it's ready for this coming merge window.
next prev parent reply other threads:[~2011-01-04 10:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 8:20 [PATCH 0/4] variable PHYS_OFFSET support Nicolas Pitre
2011-01-04 8:20 ` [PATCH 1/4] ARM: runtime patching of __virt_to_phys() and __phys_to_virt() Nicolas Pitre
2011-01-04 8:45 ` Russell King - ARM Linux
2011-01-04 14:32 ` Nicolas Pitre
2011-01-04 16:53 ` Russell King - ARM Linux
2011-01-04 17:50 ` Nicolas Pitre
2011-01-04 18:06 ` Russell King - ARM Linux
2011-01-04 18:25 ` David Brown
2011-01-04 18:33 ` Nicolas Pitre
2011-01-04 19:00 ` David Brown
2011-01-04 20:17 ` Russell King - ARM Linux
2011-01-04 18:29 ` Nicolas Pitre
2011-01-04 8:20 ` [PATCH 2/4] ARM: make PHYS_OFFSET actually variable Nicolas Pitre
2011-01-04 12:30 ` Russell King - ARM Linux
2011-01-04 17:54 ` Nicolas Pitre
2011-01-04 8:20 ` [PATCH 3/4] ARM: module support for CONFIG_ARM_PATCH_PHYS_VIRT Nicolas Pitre
2011-01-04 10:06 ` Russell King - ARM Linux
2011-01-04 8:20 ` [PATCH 4/4] ARM: support for Thumb-2 instructions with CONFIG_ARM_PATCH_PHYS_VIRT Nicolas Pitre
2011-01-10 22:20 ` Dave Martin
2011-01-10 22:45 ` Nicolas Pitre
2011-01-10 23:24 ` Russell King - ARM Linux
2011-01-10 23:57 ` Nicolas Pitre
2011-01-04 10:41 ` Russell King - ARM Linux [this message]
2011-01-04 14:37 ` [PATCH 0/4] variable PHYS_OFFSET support Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104104112.GB16671@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).