From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Tue, 4 Jan 2011 14:58:18 +0100 Subject: [PATCH v2 06/10] ARM: mx28: update clocks for dual fec support In-Reply-To: <1294133056-21195-7-git-send-email-shawn.guo@freescale.com> References: <1294133056-21195-1-git-send-email-shawn.guo@freescale.com> <1294133056-21195-7-git-send-email-shawn.guo@freescale.com> Message-ID: <20110104135818.GD25121@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Shawn, On Tue, Jan 04, 2011 at 05:24:12PM +0800, Shawn Guo wrote: > Register clocks fec.0 and fec.1 for dual fec support. > > Signed-off-by: Shawn Guo > --- > Changes for v2: > - Rebase the patch against patch below which gets fundamental > clocks explicitly called in clk_enable. > [PATCH v4] ARM: mxs: Change duart device to use amba-pl011 > - Register clocks fec.0 and fec.1 respectively than use wildcard > NULL for both instances. > > arch/arm/mach-mxs/clock-mx28.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c > index f20b254..f79587b 100644 > --- a/arch/arm/mach-mxs/clock-mx28.c > +++ b/arch/arm/mach-mxs/clock-mx28.c > @@ -607,6 +607,7 @@ static struct clk_lookup lookups[] = { > /* for amba-pl011 driver */ > _REGISTER_CLOCK("duart", NULL, uart_clk) > _REGISTER_CLOCK("fec.0", NULL, fec_clk) > + _REGISTER_CLOCK("fec.1", NULL, fec_clk) Did you verify this works as intended? I didn't and consider it possible that after clk_enable("fec.0"); clk_enable("fec.1"); clk_disable("fec.1"); the clk is off. Probably it just works, just want to prevent hard to find bugs ... Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |