From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry
Date: Tue, 4 Jan 2011 17:33:01 +0000 [thread overview]
Message-ID: <20110104173301.GA25976@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110104140031.GE25121@pengutronix.de>
On Tue, Jan 04, 2011 at 03:00:31PM +0100, Uwe Kleine-K?nig wrote:
> On Tue, Jan 04, 2011 at 02:02:55PM +0200, Felipe Balbi wrote:
> > GENERIC_HARDIRQS is defined under kernel/irq/Kconfig,
> > so it's safe to drop the duplicated entry and simply
> > select HAVE_GENERIC_HARDIRQS.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > arch/arm/Kconfig | 8 +-------
> > 1 files changed, 1 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index d56d21c0..e6f0f8b 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -15,6 +15,7 @@ config ARM
> > select HAVE_FTRACE_MCOUNT_RECORD if (!XIP_KERNEL)
> > select HAVE_DYNAMIC_FTRACE if (!XIP_KERNEL)
> > select HAVE_GENERIC_DMA_COHERENT
> > + select HAVE_GENERIC_HARDIRQS
> > select HAVE_KERNEL_GZIP
> > select HAVE_KERNEL_LZO
> > select HAVE_KERNEL_LZMA
> > @@ -88,10 +89,6 @@ config MCA
> > <file:Documentation/mca.txt> (and especially the web page given
> > there) before attempting to build an MCA bus kernel.
> >
> > -config GENERIC_HARDIRQS
> > - bool
> > - default y
> > -
> > config STACKTRACE_SUPPORT
> > bool
> > default y
> > @@ -171,9 +168,6 @@ config FIQ
> > config ARCH_MTD_XIP
> > bool
> >
> > -config GENERIC_HARDIRQS_NO__DO_IRQ
> > - def_bool y
> > -
> You didn't mention this change in the commit log. Is this duplicated,
> too or did it just slip through?
If you look at kernel/irq/Kconfig (as I did with the original patch)
you'd notice kernel/irq/Kconfig defines both of these symbols being
removed when HAVE_GENERIC_HARDIRQS is enabled.
If you read the discussion in the previous version of this patch set,
you'd notice that the removal of this was specifically requested.
It's very tiresome to have to re-explain these things. Please take
some more time to research the points you bring up, rather than
impulse-replying.
next prev parent reply other threads:[~2011-01-04 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 12:02 [PATCH 0/4] ARM IRQ Changes Felipe Balbi
2011-01-04 12:02 ` [PATCH 1/4] arm: omap: gpio: don't access irq_desc array directly Felipe Balbi
2011-01-05 0:24 ` Kevin Hilman
2011-01-05 6:47 ` Felipe Balbi
2011-01-05 17:11 ` Kevin Hilman
2011-01-04 12:02 ` [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry Felipe Balbi
2011-01-04 14:00 ` Uwe Kleine-König
2011-01-04 14:09 ` Felipe Balbi
2011-01-04 17:33 ` Russell King - ARM Linux [this message]
2011-01-04 20:54 ` Uwe Kleine-König
2011-01-05 6:51 ` Felipe Balbi
2011-01-04 12:02 ` [PATCH 3/4] arm: Kconfig: remove duplicated SPARSE_IRQ entry Felipe Balbi
2011-01-04 12:02 ` [PATCH 4/4] arm: Kconfig: allow OMAP to use sparse IRQ numbering Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2011-01-04 10:38 [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104173301.GA25976@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).