linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 5/5] ARM: P2V: extend to 16-bit translation offsets
Date: Wed, 5 Jan 2011 00:15:24 +0000	[thread overview]
Message-ID: <20110105001524.GI24935@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.1101041628060.22191@xanadu.home>

On Tue, Jan 04, 2011 at 04:41:34PM -0500, Nicolas Pitre wrote:
> I'd suggest making the type argument into a mask instead, something 
> like:
> 
> 	__pv_stub(x, t, "add", 0xff000000);
> #ifdef CONFIG_ARM_PATCH_PHYS_VIRT_16BIT
> 	__pv_stub(t, t, "add", 0x00ff0000);
> #endif
> 
> Reasons for this are multiple:
> 
>  - This would simplifies the patching code as the rotation bitfield in 
>    the instruction would already be set appropriately for the desired 
>    value by the assembler.  Would only suffice to test one bit in that 
>    field to determine the required constant to patch in.
> 
>  - For the Thumb2 build, we want the assembler to select the appropriate 
>    encoding flavor for the add instruction from all the possibilities.  
>    Giving it a constant with all bits set nicely solves this issue.
> 
> If further distinctions are needed in the future then we can use the 6 
> middle bits to encode alternatives.

Lets go with 0x81000000 and 0x0081000000 for the first then.  We can
count up with the 6-bit value from there.

  reply	other threads:[~2011-01-05  0:15 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 20:20 [RFC 0/5] runtime P2V translations Russell King - ARM Linux
2011-01-04 20:22 ` [RFC 1/5] ARM: P2V: separate PHYS_OFFSET from platform definitions Russell King - ARM Linux
2011-01-04 21:10   ` Nicolas Pitre
2011-01-05 22:30     ` Russell King - ARM Linux
2011-01-04 21:23   ` Uwe Kleine-König
2011-01-05  0:04     ` Russell King - ARM Linux
2011-01-05  6:25       ` Uwe Kleine-König
2011-01-05  3:28   ` viresh kumar
2011-01-05 17:04   ` H Hartley Sweeten
2011-01-06  5:02   ` Magnus Damm
2011-02-07 15:57     ` Tony Lindgren
2011-02-07 16:36   ` Jean-Christophe PLAGNIOL-VILLARD
2011-02-08 11:22   ` Wan ZongShun
2011-02-17  5:33   ` Kukjin Kim
2011-02-17 15:16   ` Eric Miao
2011-02-17 18:07     ` JD (Jiandong) Zheng
2011-01-04 20:22 ` [RFC 2/5] ARM: P2V: avoid initializers and assembly using PHYS_OFFSET Russell King - ARM Linux
2011-01-04 21:12   ` Nicolas Pitre
2011-01-06  8:51   ` Sascha Hauer
2011-01-06  9:08     ` Russell King - ARM Linux
2011-02-07 15:59       ` Tony Lindgren
2011-02-07 16:51   ` Uwe Kleine-König
2011-02-07 16:52     ` Uwe Kleine-König
2011-02-17  5:36   ` Kukjin Kim
2011-02-17 14:11   ` Russell King - ARM Linux
2011-02-17 16:19     ` David Brown
2011-02-17 15:16   ` Eric Miao
2011-01-04 20:22 ` [RFC 3/5] ARM: P2V: make head.S use PLAT_PHYS_OFFSET Russell King - ARM Linux
2011-01-04 21:13   ` Nicolas Pitre
2011-02-07 16:12     ` Tony Lindgren
2011-01-04 20:23 ` [RFC 4/5] ARM: P2V: introduce phys_to_virt/virt_to_phys runtime patching Russell King - ARM Linux
2011-01-04 21:27   ` Nicolas Pitre
2011-01-05  0:08     ` Russell King - ARM Linux
2011-02-07 16:15       ` Tony Lindgren
2011-02-09 12:17   ` Jamie Iles
2011-02-09 13:06     ` Russell King - ARM Linux
2011-01-04 20:23 ` [RFC 5/5] ARM: P2V: extend to 16-bit translation offsets Russell King - ARM Linux
2011-01-04 21:41   ` Nicolas Pitre
2011-01-05  0:15     ` Russell King - ARM Linux [this message]
2011-01-04 23:14   ` David Brown
2011-01-04 23:18   ` David Brown
2011-01-05  0:13     ` Russell King - ARM Linux
2011-02-07 16:19       ` Tony Lindgren
2011-02-17 14:15 ` [RFC 0/5] runtime P2V translations Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105001524.GI24935@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).