linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry
Date: Wed, 5 Jan 2011 08:51:25 +0200	[thread overview]
Message-ID: <20110105065124.GD2458@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110104205445.GF25121@pengutronix.de>

Hi,

On Tue, Jan 04, 2011 at 09:54:45PM +0100, Uwe Kleine-K?nig wrote:
> > If you look at kernel/irq/Kconfig (as I did with the original patch)
> > you'd notice kernel/irq/Kconfig defines both of these symbols being
> > removed when HAVE_GENERIC_HARDIRQS is enabled.
> > 
> > If you read the discussion in the previous version of this patch set,
> > you'd notice that the removal of this was specifically requested.
> > 
> > It's very tiresome to have to re-explain these things.  Please take
> > some more time to research the points you bring up, rather than
> I don't agree here 100%.  IMHO the commit log was not good enough for
> the change introduced by the patch (and Felipe's reply suggests that he
> agrees).  I could still research it, but:
> 
>  - it was not obvious for me there was a previous version (no "v2" or
>    similar in the patch subject);
>  - for me it would take say 5 minutes to check, the author knows
>    the answer to my question immediately (at least he should);
>  - after a research I could suggest a better wording, but I don't care
>    much if it's me or Felipe who comes up with a better text.
> 
> So all in all I'm still confident that my mail was OK.

No need to fight over a simple change, here it is updated.

-- 
balbi

  reply	other threads:[~2011-01-05  6:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04 12:02 [PATCH 0/4] ARM IRQ Changes Felipe Balbi
2011-01-04 12:02 ` [PATCH 1/4] arm: omap: gpio: don't access irq_desc array directly Felipe Balbi
2011-01-05  0:24   ` Kevin Hilman
2011-01-05  6:47     ` Felipe Balbi
2011-01-05 17:11       ` Kevin Hilman
2011-01-04 12:02 ` [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry Felipe Balbi
2011-01-04 14:00   ` Uwe Kleine-König
2011-01-04 14:09     ` Felipe Balbi
2011-01-04 17:33     ` Russell King - ARM Linux
2011-01-04 20:54       ` Uwe Kleine-König
2011-01-05  6:51         ` Felipe Balbi [this message]
2011-01-04 12:02 ` [PATCH 3/4] arm: Kconfig: remove duplicated SPARSE_IRQ entry Felipe Balbi
2011-01-04 12:02 ` [PATCH 4/4] arm: Kconfig: allow OMAP to use sparse IRQ numbering Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2011-01-04 10:38 [PATCH 2/4] arm: Kconfig: remove duplicated GENERIC_HARDIRQS entry Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105065124.GD2458@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).