From: ben-i2c@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit
Date: Wed, 5 Jan 2011 09:19:15 +0000 [thread overview]
Message-ID: <20110105091915.GV27131@trinity.fluff.org> (raw)
In-Reply-To: <20110105082445.GL25121@pengutronix.de>
On Wed, Jan 05, 2011 at 09:24:45AM +0100, Uwe Kleine-K?nig wrote:
> a bit of explanation would be nice here. Something like:
>
> Subject: i2c-pxa: make sure the remove callback is called on unbind
>
> When a "pxa2xx-i2c" device was unbound (e.g. via sysfs) the remove
> callback was not called because it was discarded after boot or module
> load time. Because of that the resources allocated in probe were not
> freed and so a rebind was impossible.
>
> Fix that by moving the remove callback to .devexit.text.
>
> This way everyone can understand that a real bug is fixed here.
agreed, please re-submit
--
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-01-05 9:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 2:05 [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 2/6] mfp-pxa27x: correct naming of GPIO13_KP_DKIN_7 Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 3/6] pxa2xx: update stored gpio settings in pxa2xx_mfp_set_lpm() Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 4/6] pcmcia: limit pxa2xx_balloon3 subdriver to balloon3 platform Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 5/6] pcmcia: limit pxa2xx_trizeps4 subdriver to trizeps4 platform Dmitry Eremin-Solenikov
2011-01-05 2:05 ` [PATCH 6/6] Fix eseries compilation if w100fb is not compiled in kernel Dmitry Eremin-Solenikov
2011-01-05 8:27 ` Uwe Kleine-König
2011-01-05 10:54 ` Uwe Kleine-König
2011-01-05 11:17 ` Dmitry Eremin-Solenikov
2011-01-05 8:24 ` [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Uwe Kleine-König
2011-01-05 9:19 ` Ben Dooks [this message]
2011-01-06 11:01 ` [PATCH] i2c-pxa: fix unbidding/rebidding of the device Dmitry Eremin-Solenikov
2011-01-06 12:40 ` Uwe Kleine-König
2011-01-08 16:06 ` [PATCH] i2c-pxa: fix unbinding/rebinding " Dmitry Eremin-Solenikov
2011-01-08 16:18 ` Uwe Kleine-König
2011-02-15 13:59 ` Dmitry Eremin-Solenikov
2011-02-15 16:23 ` Uwe Kleine-König
2011-01-05 12:17 ` [PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit Ben Dooks
2011-01-08 17:42 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105091915.GV27131@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).