From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Wed, 5 Jan 2011 11:54:04 +0100 Subject: [PATCH 6/6] Fix eseries compilation if w100fb is not compiled in kernel In-Reply-To: <20110105082748.GM25121@pengutronix.de> References: <1294193110-23958-1-git-send-email-dbaryshkov@gmail.com> <1294193110-23958-6-git-send-email-dbaryshkov@gmail.com> <20110105082748.GM25121@pengutronix.de> Message-ID: <20110105105404.GP25121@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello again, On Wed, Jan 05, 2011 at 09:27:49AM +0100, Uwe Kleine-K?nig wrote: > Hello Dmitry, > > On Wed, Jan 05, 2011 at 05:05:10AM +0300, Dmitry Eremin-Solenikov wrote: > > e800_tg_change depends on w100fb_gpio_read/write API which is only present > > if w100fb is compiled in kernel. > > > > Signed-off-by: Dmitry Eremin-Solenikov > > Cc: Ian Molton > > --- > > arch/arm/mach-pxa/eseries.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-pxa/eseries.c b/arch/arm/mach-pxa/eseries.c > > index b25690c..ed2c157 100644 > > --- a/arch/arm/mach-pxa/eseries.c > > +++ b/arch/arm/mach-pxa/eseries.c > > @@ -829,6 +829,7 @@ static struct w100_mem_info e800_w100_mem_info = { > > > > static void e800_tg_change(struct w100fb_par *par) > > { > > +#ifdef FB_W100 > CONFIG_FB_W100? > > > unsigned long tmp; > > > > tmp = w100fb_gpio_read(W100_GPIO_PORT_A); > > @@ -837,6 +838,7 @@ static void e800_tg_change(struct w100fb_par *par) > > else > > tmp &= ~0x100; > > w100fb_gpio_write(W100_GPIO_PORT_A, tmp); > > +#endif > What happens if FB_W100=m? The code isn't compiled in, would it still > be necessary? did you see commit a74b74a5555c741ed3df896096e33b853995631e? http://git.kernel.org/linus/a74b74a5555c741ed3df896096e33b853995631e Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |