linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support
Date: Wed, 5 Jan 2011 22:03:49 +0000	[thread overview]
Message-ID: <20110105220349.GA22857@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D231B5F.7030607@mvista.com>

On Tue, Jan 04, 2011 at 04:06:39PM +0300, Sergei Shtylyov wrote:
>    Putting MUSB DMA enignes into drivers/dma/ is the same as taking *any* 
> chip capable of bus-mastering DMA, "separating" its bus mastering related 
> code from its driver and putting this code into drivers/dma/. This 
> doesn't make sense, in my opinion. drivers/dma/ is for the dedicated DMA 
> controllers (which can *optionally* serve the slave devices).

Then why is it already separated into its own self-contained driver?

If it's because the DMA engine is used for different peripherals (possibly
re-used for different peripherals), then it does seem to make sense to
have it separated via some API.  And if possible that API might should
be something generic instead of specific.

Even more reason to do this is if the device being fed by the DMA has
been re-used with different DMA hardware (which I believe is the case
with MUSB.)  What if this different DMA hardware then gets re-used for
other devices?  Should they all implement the same custom API or try
for a generic API?

  parent reply	other threads:[~2011-01-05 22:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-15 18:14 [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support Sergei Shtylyov
2010-05-28 20:55 ` Sergei Shtylyov
2010-09-28  9:13 ` Linus Walleij
2010-09-28 10:13   ` Sergei Shtylyov
2011-01-03 16:06 ` Sergei Shtylyov
2011-01-03 16:34   ` Russell King - ARM Linux
2011-01-03 17:01     ` Gupta, Ajay Kumar
2011-01-03 17:07       ` Sergei Shtylyov
2011-01-03 17:15         ` Gupta, Ajay Kumar
2011-01-03 20:44           ` Felipe Balbi
2011-01-04 13:06             ` Sergei Shtylyov
2011-01-04 14:06               ` Felipe Balbi
2011-01-04 14:40                 ` Ming Lei
2011-01-04 14:56                   ` Felipe Balbi
2011-01-04 15:41                     ` Ming Lei
2011-01-04 18:42                       ` Felipe Balbi
2011-01-04 18:50                         ` Sergei Shtylyov
2011-01-04 16:37                 ` Sergei Shtylyov
2011-01-05 22:03               ` Russell King - ARM Linux [this message]
2011-01-03 17:19         ` Russell King - ARM Linux
2011-01-03 20:49           ` Felipe Balbi
2011-01-04 19:12             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105220349.GA22857@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).