From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard.zhao@freescale.com (Richard Zhao) Date: Thu, 6 Jan 2011 18:43:59 +0800 Subject: [PATCH v4 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h In-Reply-To: <20110106103241.GG26009@pengutronix.de> References: <1293708306-20170-1-git-send-email-richard.zhao@freescale.com> <1293708306-20170-2-git-send-email-richard.zhao@freescale.com> <1293708306-20170-3-git-send-email-richard.zhao@freescale.com> <1293708306-20170-4-git-send-email-richard.zhao@freescale.com> <1293708306-20170-5-git-send-email-richard.zhao@freescale.com> <20110106065935.GA15509@shlinux1.ap.freescale.net> <20110106101639.GE26009@pengutronix.de> <20110106102918.GA2349@shlinux1.ap.freescale.net> <20110106103241.GG26009@pengutronix.de> Message-ID: <20110106104359.GA25563@shlinux1.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 06, 2011 at 11:32:41AM +0100, Sascha Hauer wrote: > On Thu, Jan 06, 2011 at 06:29:19PM +0800, Richard Zhao wrote: > > On Thu, Jan 06, 2011 at 11:16:39AM +0100, Sascha Hauer wrote: > > > On Thu, Jan 06, 2011 at 02:59:36PM +0800, Richard Zhao wrote: > > > > Hello Sascha, > > > > > > > > On Thu, Dec 30, 2010 at 07:25:04PM +0800, Richard Zhao wrote: > > > > > IOMUX_CONFIG_GPIO is not for iomux-v3. It's for old freescale > > > > > iomux routines. Remove it. > > > > > > > > > > Signed-off-by: Richard Zhao > > > > > Acked-by: Uwe Kleine-K?nig > > > > If you don't have comments, could you please merge this patch? > > > > It's causing arch/arm/plat-mxc/include/mach/iomux-mx50.h incomplete. > > > > > > I didn't apply it because it conflicts with current imx-for-2.6.38 > > > branch. Other than that I don't find the enum very useful at all, > > > because we have problems with very long lines in these files and > > > using IOMUX_CONFIG_ALT0 where we could use 0 does not exactly improve > > > the situation. > > Yes, correct. IOMUX_CONFIG_ALT0-7 is ok. But IOMUX_CONFIG_SION is more > > readable than 0x1 << 4, isn't it? If you don't agree put IOMUX_CONFIG_SION > > in iomux-v3.h, shall I put it in iomux-mx50.h? > > IOMUX_CONFIG_SION is ok, but please drop the rest. ok to put it into iomux-v3.h? I will sent out one patch. Richard > > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >