From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] add CNS3xxx AHCI support
Date: Thu, 6 Jan 2011 13:51:57 +0300 [thread overview]
Message-ID: <20110106105157.GA9560@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTinxNtzpzUn0=-iph_N7tffM6Nu++J9qNNhcp8pX@mail.gmail.com>
On Thu, Jan 06, 2011 at 02:43:08PM +0800, Lin Mac wrote:
[...]
> > It is overkill to rename the entirety of ahci_platform just for one override
> > function.
> > This sort of thing I would have expected to be added directly to
> > ahci_platform.c.
> It might be overkill for only one controller. but it is more clean and
> readable to have different SoC specific changes in separate files,
> especially when more SoCs need to make similar changes.
I think that renaming the file is not necessary. You can just
rename the module in the makefile.
Personally I like the current approach more than putting
controller-specific fixups directly into ahci_platform.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru at gmail.com
next prev parent reply other threads:[~2011-01-06 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 5:43 [PATCH v2 0/3] add CNS3xxx AHCI support mkl0301 at gmail.com
2011-01-05 5:43 ` [PATCH v2 1/3] ahci_platform: rename to ahci_pltfm, but keep the original module name mkl0301 at gmail.com
2011-01-05 5:43 ` [PATCH v2 2/3] ahci_pltfm: switch to module device table matching mkl0301 at gmail.com
2011-01-06 10:53 ` Anton Vorontsov
2011-01-05 5:43 ` [PATCH v2 3/3] ahci_platform: add support for CNS3xxx SoC devices mkl0301 at gmail.com
2011-01-06 11:02 ` Anton Vorontsov
2011-01-05 18:15 ` [PATCH v2 0/3] add CNS3xxx AHCI support Jeff Garzik
2011-01-06 6:43 ` Lin Mac
2011-01-06 10:51 ` Anton Vorontsov [this message]
2011-01-06 16:18 ` Lin Mac
2011-01-06 23:17 ` Jeff Garzik
2011-01-07 15:47 ` Anton Vorontsov
2011-01-07 23:44 ` Lin Mac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106105157.GA9560@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).