linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD
Date: Fri, 7 Jan 2011 18:51:54 +0100	[thread overview]
Message-ID: <201101071851.54872.arnd@arndb.de> (raw)
In-Reply-To: <ABCC071A-5598-48AA-9545-2712FA0BB624@marvell.com>

On Friday 07 January 2011, Philip Rakity wrote:
> Thanks for the suggestion.  Let me see if I can implement this.  
> 
> A couple of points first
> 
> a) current implementation once PXA168/910 is selected will no longer show MMP2 boards so it is also broken.  Play around and you will see the issues

I didn't see it on the version I'm looking at now, but if it's inconsistent or
allows you to select combinationst that cannot be built, then it should be fixed.

> My proposed patch did the following
> a) ARCH_MMP is set when PXA168, PXA910 or MMP2 are selected (from arch/arm)
> b) Board selection uses the PXA168/PXA910/MMP2 to show correct board.

Yes, that is what I thought, but it is inconsistent with how other platforms do this.
Usually, the top-level selection chooses one source directory, and anything specific
to that platform is handled by that Kconfig.

> If I understand what you are suggesting is the following
> a) leave ARCH_MMP is system selection alone -- 
> b) move speciific CPU selection to where board selection is now (cpu/arch/mach-mmp)

Right.

> c) what do with development boards ?  select all of them for the CPU Type ?  
>
> Point me to a Kconfig that does what you are suggesting as an example and I can try out the suggestion.

Just put it below the CPU selection.

OMAP does something like this -- you first select either OMAP1 or OMAP2/3/4, then
the families in the latter case, and finally the boards.

You can do the same by first giving the choice between ARMv6 and PXA168/910, and
then showing the boards below the CPU. There are multiple ways of doing this
that lead to the same result.

	Arnd

  reply	other threads:[~2011-01-07 17:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22  7:09 [PATCH 15/23] Alternative mmc structure to support pxa168, pxa910, mmp2 family SD Philip Rakity
2010-12-22 14:10 ` Arnd Bergmann
2010-12-22 22:58   ` Philip Rakity
2010-12-31  5:46     ` Haojian Zhuang
2010-12-31  6:03       ` Philip Rakity
2010-12-31  6:46         ` Haojian Zhuang
2010-12-31 22:08           ` Mark Brown
2011-01-04  6:10             ` zhangfei gao
2011-01-06 19:29         ` Arnd Bergmann
2011-01-07 16:48           ` Philip Rakity
2011-01-07 17:51             ` Arnd Bergmann [this message]
2011-01-07 19:26               ` [PATCH 1/2] mach-mmp: MMP2 Drive Strength FAST using wrong value Philip Rakity
2011-01-07 19:27                 ` [PATCH 2/2] mach-mmp: PXA910 " Philip Rakity
2011-01-08  5:28                   ` [PATCH] mach-mmp: Fix Kconfig to allow correct PXA Selections Philip Rakity
2011-01-12 23:58                   ` [PATCH 2/2] mach-mmp: PXA910 Drive Strength FAST using wrong value Eric Miao
2011-01-12 23:03                 ` [PATCH 1/2] mach-mmp: MMP2 " Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101071851.54872.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).