* suspicious code in linux/arch/arm/common/sa1111.c
@ 2010-11-16 9:07 Pavel Machek
2010-11-16 9:09 ` Eric Miao
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2010-11-16 9:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi!
Is this good idea?
Signed-off-by: Pavel Machek <pma@sysgo.com>
diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
--- linux.ofic//arch/arm/common/sa1111.c 2010-10-17 20:31:13.000000000 +0200
+++ linux/arch/arm/common/sa1111.c 2010-11-05 10:44:17.000000000 +0100
@@ -282,7 +312,7 @@
for (i = 0; i < 8; i++) {
sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
- if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
+ if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
break;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* suspicious code in linux/arch/arm/common/sa1111.c
2010-11-16 9:07 suspicious code in linux/arch/arm/common/sa1111.c Pavel Machek
@ 2010-11-16 9:09 ` Eric Miao
2011-01-09 7:14 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Eric Miao @ 2010-11-16 9:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 16, 2010 at 5:07 PM, Pavel Machek <pma@sysgo.com> wrote:
> Hi!
>
> Is this good idea?
>
> Signed-off-by: Pavel Machek <pma@sysgo.com>
Yep, obviously was a typo.
>
> diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
> --- linux.ofic//arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200
> +++ linux/arch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100
> @@ -282,7 +312,7 @@
> ? ? ? ?for (i = 0; i < 8; i++) {
> ? ? ? ? ? ? ? ?sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
> ? ? ? ? ? ? ? ?sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
> - ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
> + ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
> ? ? ? ? ? ? ? ? ? ? ? ?break;
> ? ? ? ?}
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* suspicious code in linux/arch/arm/common/sa1111.c
2010-11-16 9:09 ` Eric Miao
@ 2011-01-09 7:14 ` Pavel Machek
2011-01-10 22:38 ` Eric Miao
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2011-01-09 7:14 UTC (permalink / raw)
To: linux-arm-kernel
On Tue 2010-11-16 17:09:59, Eric Miao wrote:
> On Tue, Nov 16, 2010 at 5:07 PM, Pavel Machek <pma@sysgo.com> wrote:
> > Hi!
> >
> > Is this good idea?
> >
> > Signed-off-by: Pavel Machek <pma@sysgo.com>
>
> Yep, obviously was a typo.
Can you apply the patch? Or should I re--generate one with better changelog?
> > diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
> > --- linux.ofic//arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200
> > +++ linux/arch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100
> > @@ -282,7 +312,7 @@
> > ? ? ? ?for (i = 0; i < 8; i++) {
> > ? ? ? ? ? ? ? ?sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
> > ? ? ? ? ? ? ? ?sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
> > - ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
> > + ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
> > ? ? ? ? ? ? ? ? ? ? ? ?break;
> > ? ? ? ?}
> >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 4+ messages in thread* suspicious code in linux/arch/arm/common/sa1111.c
2011-01-09 7:14 ` Pavel Machek
@ 2011-01-10 22:38 ` Eric Miao
0 siblings, 0 replies; 4+ messages in thread
From: Eric Miao @ 2011-01-10 22:38 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jan 9, 2011 at 1:14 AM, Pavel Machek <pavel@ucw.cz> wrote:
> On Tue 2010-11-16 17:09:59, Eric Miao wrote:
>> On Tue, Nov 16, 2010 at 5:07 PM, Pavel Machek <pma@sysgo.com> wrote:
>> > Hi!
>> >
>> > Is this good idea?
>> >
>> > Signed-off-by: Pavel Machek <pma@sysgo.com>
>>
>> Yep, obviously was a typo.
>
> Can you apply the patch? Or should I re--generate one with better changelog?
Applied with subject line as below, which I guess is more specific?
Subject: ARM: sa1111: fix typo in sa1111_retrigger_lowirq()
>
>> > diff -ur linux.ofic//arch/arm/common/sa1111.c linux/arch/arm/common/sa1111.c
>> > --- linux.ofic//arch/arm/common/sa1111.c ? ? ? ?2010-10-17 20:31:13.000000000 +0200
>> > +++ linux/arch/arm/common/sa1111.c ? ? ?2010-11-05 10:44:17.000000000 +0100
>> > @@ -282,7 +312,7 @@
>> > ? ? ? ?for (i = 0; i < 8; i++) {
>> > ? ? ? ? ? ? ? ?sa1111_writel(ip0 ^ mask, mapbase + SA1111_INTPOL0);
>> > ? ? ? ? ? ? ? ?sa1111_writel(ip0, mapbase + SA1111_INTPOL0);
>> > - ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR1) & mask)
>> > + ? ? ? ? ? ? ? if (sa1111_readl(mapbase + SA1111_INTSTATCLR0) & mask)
>> > ? ? ? ? ? ? ? ? ? ? ? ?break;
>> > ? ? ? ?}
>> >
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at ?http://www.tux.org/lkml/
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-10 22:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-16 9:07 suspicious code in linux/arch/arm/common/sa1111.c Pavel Machek
2010-11-16 9:09 ` Eric Miao
2011-01-09 7:14 ` Pavel Machek
2011-01-10 22:38 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).