From: wim@iguana.be (Wim Van Sebroeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: add support for the Synopsys DesignWare WDT
Date: Mon, 10 Jan 2011 14:58:10 +0100 [thread overview]
Message-ID: <20110110135810.GN3801@infomag.iguana.be> (raw)
In-Reply-To: <1294656906-24239-1-git-send-email-jamie@jamieiles.com>
Hi Jamie,
> +config DW_WATCHDOG
> + tristate "Synopsys DesignWare watchdog"
> + select WATCHDOG_NOWAYOUT
I overlooked something: If your watchdog driver cannot be stopped once it's started,
then it's best to add a comment about that in your code. Selecting the WATCHDOG_NOWAYOUT
feauture (which is overall for all drivers) is not the way to do it properly.
What you should do is add a timer that ticks the watchdog if /dev/watchdog is closed.
Examples for this functionality can be found in at91sam9_wdt.c, pika_wdt.c, ...
Sorry,
Wim.
next prev parent reply other threads:[~2011-01-10 13:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 10:55 [PATCH] watchdog: add support for the Synopsys DesignWare WDT Jamie Iles
2011-01-10 13:21 ` Wim Van Sebroeck
2011-01-10 13:33 ` Jamie Iles
2011-01-10 13:58 ` Wim Van Sebroeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-10 15:59 Jamie Iles
2011-01-12 5:16 ` viresh kumar
2011-01-12 8:24 ` Jamie Iles
2011-01-12 8:57 ` viresh kumar
2011-01-12 9:07 ` Russell King - ARM Linux
2011-01-12 11:30 ` Jamie Iles
2011-01-12 11:38 ` viresh kumar
2011-01-12 12:33 ` Jamie Iles
2011-01-21 18:08 ` Jamie Iles
2011-01-24 4:06 ` viresh kumar
2011-01-07 11:41 Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110135810.GN3801@infomag.iguana.be \
--to=wim@iguana.be \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).